-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
K8s: Bump new KEDA image for feature preview #2681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Viet Nguyen Duc <[email protected]>
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
CI Feedback 🧐(Feedback updated until commit 2af207a)A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
Signed-off-by: Viet Nguyen Duc <[email protected]>
Signed-off-by: Viet Nguyen Duc <[email protected]>
986983a
to
2af207a
Compare
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist
PR Type
Enhancement, Tests, Documentation
Description
Added support for
enableManagedDownloads
in Selenium Grid scaler.enableManagedDownloads
for scaler configuration.Enhanced test coverage for
enableManagedDownloads
functionality.Updated documentation for Selenium Grid scaler.
enableManagedDownloads
.Minor configuration and dependency updates.
KEDA_BASED_TAG
in Makefile and fixed a condition in Helm chart dependencies.Changes walkthrough 📝
selenium_grid_scaler.go
Support managed downloads in Selenium Grid scaler
.keda/scalers/selenium_grid_scaler.go
enableManagedDownloads
field to scaler metadata.enableManagedDownloads
.getCountFromSeleniumResponse
to includeenableManagedDownloads
.selenium_grid_scaler_test.go
Add tests for managed downloads in scaler
.keda/scalers/selenium_grid_scaler_test.go
enableManagedDownloads
.enableManagedDownloads
parameter.README.md
Update README with new PR references
.keda/README.md
selenium-grid-scaler.md
Document managed downloads in Selenium Grid scaler
.keda/scalers/selenium-grid-scaler.md
enableManagedDownloads
metadata field.Makefile
Update KEDA_BASED_TAG in Makefile
Makefile
KEDA_BASED_TAG
to a new version.Chart.yaml
Fix Helm chart dependency condition
charts/selenium-grid/Chart.yaml
kube-prometheus-stack
dependency.