Skip to content

[ci] Upload autoscaling in K8s test results #2558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Conversation

selenium-ci
Copy link
Member

@selenium-ci selenium-ci commented Jan 3, 2025

User description

This PR contains the results of the autoscaling tests in Kubernetes


PR Type

Tests


Description

  • Updated Kubernetes autoscaling test results across multiple scenarios.

  • Adjusted metrics for deployment count, job count, and chaos scenarios.

  • Enhanced test data to reflect new scaling behaviors and session handling.

  • Improved consistency and accuracy in test result documentation.


Changes walkthrough 📝

Relevant files
Tests
results_test_k8s_autoscaling_deployment_count.md
Updated deployment count autoscaling test results.             

.keda/results_test_k8s_autoscaling_deployment_count.md

  • Updated test results for deployment count autoscaling.
  • Adjusted session creation times and pod scaling metrics.
  • Refined data for gaps and session closures.
  • +20/-20 
    results_test_k8s_autoscaling_deployment_count_in_chaos.md
    Updated deployment count chaos test results.                         

    .keda/results_test_k8s_autoscaling_deployment_count_in_chaos.md

  • Updated test results for deployment count under chaos.
  • Adjusted pod scaling and session metrics.
  • Improved data consistency for chaos scenarios.
  • +20/-20 
    results_test_k8s_autoscaling_deployment_count_with_node_max_sessions.md
    Updated deployment count with node max sessions results. 

    .keda/results_test_k8s_autoscaling_deployment_count_with_node_max_sessions.md

  • Updated test results for deployment count with node max sessions.
  • Adjusted scaling metrics and session handling.
  • Enhanced data for session gaps and closures.
  • +20/-20 
    results_test_k8s_autoscaling_job_count_strategy_default.md
    Updated job count strategy default test results.                 

    .keda/results_test_k8s_autoscaling_job_count_strategy_default.md

  • Updated test results for job count strategy default.
  • Adjusted pod scaling and session metrics.
  • Refined data for session handling and closures.
  • +20/-20 
    results_test_k8s_autoscaling_job_count_strategy_default_in_chaos.md
    Updated job count strategy chaos test results.                     

    .keda/results_test_k8s_autoscaling_job_count_strategy_default_in_chaos.md

  • Updated test results for job count strategy default under chaos.
  • Adjusted pod scaling and session metrics.
  • Improved data consistency for chaos scenarios.
  • +20/-20 
    results_test_k8s_autoscaling_job_count_strategy_default_with_node_max_sessions.md
    Updated job count with node max sessions results.               

    .keda/results_test_k8s_autoscaling_job_count_strategy_default_with_node_max_sessions.md

  • Updated test results for job count strategy with node max sessions.
  • Adjusted scaling metrics and session handling.
  • Enhanced data for session gaps and closures.
  • +20/-20 

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    qodo-merge-pro bot commented Jan 3, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 PR contains tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Performance Degradation

    Session creation times show significant variance between iterations, ranging from 4.55s to 51.12s, which could indicate potential performance issues in the autoscaling system.

    | 1         | 3                    | 51.12 s               | 0                         | 3                  | 3                      | 3                  | 1                    | 0    | 3               |
    | 2         | 3                    | 33.01 s               | 0                         | 1                  | 3                      | 4                  | 1                    | 1    | 0               |
    | 3         | 1                    | 13.03 s               | 0                         | 0                  | 4                      | 4                  | 1                    | 0    | 0               |
    | 4         | 3                    | 47.49 s               | 0                         | 3                  | 7                      | 7                  | 1                    | 0    | 0               |
    | 5         | 1                    | 31.93 s               | 0                         | 1                  | 8                      | 8                  | 1                    | 0    | 0               |
    | 6         | 2                    | 46.39 s               | 0                         | 2                  | 10                     | 10                 | 1                    | 0    | 10              |
    | 7         | 2                    | 13.55 s               | 0                         | 0                  | 2                      | 10                 | 1                    | 8    | 0               |
    | 8         | 2                    | 37.20 s               | 0                         | 1                  | 4                      | 11                 | 1                    | 7    | 0               |
    | 9         | 1                    | 13.56 s               | 0                         | 0                  | 5                      | 11                 | 1                    | 6    | 0               |
    | 10        | 2                    | 12.78 s               | 0                         | 0                  | 7                      | 11                 | 1                    | 4    | 0               |
    | 11        | 2                    | 35.07 s               | 0                         | 2                  | 9                      | 13                 | 1                    | 4    | 9               |
    | 12        | 3                    | 13.74 s               | 0                         | 0                  | 3                      | 13                 | 1                    | 10   | 0               |
    | 13        | 1                    | 4.55 s                | 0                         | 0                  | 4                      | 13                 | 1                    | 9    | 0               |
    | 14        | 3                    | 7.52 s                | 0                         | 0                  | 7                      | 13                 | 1                    | 6    | 0               |
    | 15        | 1                    | 4.93 s                | 0                         | 0                  | 8                      | 10                 | 1                    | 2    | 0               |
    | 16        | 2                    | 28.89 s               | 0                         | 2                  | 10                     | 12                 | 1                    | 2    | 10              |
    | 17        | 2                    | 5.27 s                | 0                         | 0                  | 2                      | 12                 | 1                    | 10   | 0               |
    | 18        | 1                    | 13.58 s               | 0                         | 0                  | 3                      | 12                 | 1                    | 9    | 0               |
    | 19        | 2                    | 9.77 s                | 0                         | 0                  | 5                      | 12                 | 1                    | 7    | 0               |
    | 20        | 3                    | 6.80 s                | 0                         | 0                  | 8                      | 12                 | 1                    | 4    | 0               |
    Failed Sessions

    Initial iteration shows failed session creation attempts which could indicate configuration or startup issues in the autoscaling system.

    | 1         | 1                    | 0.10 s                | 1                         | 0                  | 0                      | 0                  | 1                    | 0    | 0               |
    | 2         | 1                    | 46.67 s               | 0                         | 1                  | 1                      | 1                  | 1                    | 0    | 0               |

    Copy link

    qodo-merge-pro bot commented Jan 3, 2025

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Possible issue
    Initial session creation failures should be eliminated to ensure reliable system startup

    The initial session creation failures in iteration 1 should be investigated and
    addressed. Having 2 failed sessions at startup could indicate configuration or
    resource availability issues.

    .keda/results_test_k8s_autoscaling_deployment_count_with_node_max_sessions.md [3]

    -| 1         | 2                    | 0.08 s                | 2                         | 0                  | 0                      | 0                  | 3                    | 0    | 0               |
    +| 1         | 2                    | 30.00 s               | 0                         | 2                  | 2                      | 2                  | 3                    | 0    | 0               |
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    Why: The suggestion identifies a critical startup reliability issue where initial session creation is failing, which could impact system availability and user experience.

    8
    System startup reliability needs improvement to prevent initial session creation failures

    Initial iteration shows 3 failed session creations, indicating potential startup
    issues that need investigation and fixing.

    .keda/results_test_k8s_autoscaling_job_count_strategy_default_with_node_max_sessions.md [3]

    -| 1         | 3                    | 0.07 s                | 3                         | 0                  | 0                      | 0                  | 3                    | 0    | 0               |
    +| 1         | 3                    | 30.00 s               | 0                         | 3                  | 3                      | 3                  | 3                    | 0    | 0               |
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    Why: The suggestion highlights a significant reliability issue where all three initial session creations are failing, indicating a potential systemic startup problem.

    8

    @VietND96 VietND96 merged commit 250f8f1 into trunk Jan 3, 2025
    2 of 19 checks passed
    @VietND96 VietND96 deleted the autoscaling-results branch January 3, 2025 21:38
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants