Skip to content

Restructuring and formatting #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 16, 2021
Merged

Restructuring and formatting #56

merged 8 commits into from
Mar 16, 2021

Conversation

hhsecond
Copy link
Contributor

@hhsecond hhsecond commented Mar 6, 2021

Restructure modules into multiple files and black formatting.

@codecov
Copy link

codecov bot commented Mar 6, 2021

Codecov Report

Merging #56 (ceb88c7) into master (ceb88c7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #56   +/-   ##
=======================================
  Coverage   97.14%   97.14%           
=======================================
  Files           6        6           
  Lines         666      666           
=======================================
  Hits          647      647           
  Misses         19       19           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ceb88c7...6489884. Read the comment docs.

@hhsecond hhsecond requested review from DvirDukhan and alonre24 March 6, 2021 18:08
@lgtm-com
Copy link

lgtm-com bot commented Mar 6, 2021

This pull request introduces 3 alerts and fixes 2 when merging 0cba685 into f70af12 - view on LGTM.com

new alerts:

  • 3 for Unused import

fixed alerts:

  • 1 for Conflicting attributes in base classes
  • 1 for Missing call to `__init__` during object initialization

@lgtm-com
Copy link

lgtm-com bot commented Mar 8, 2021

This pull request introduces 3 alerts and fixes 2 when merging fede87d into ceb88c7 - view on LGTM.com

new alerts:

  • 3 for Unused import

fixed alerts:

  • 1 for Conflicting attributes in base classes
  • 1 for Missing call to `__init__` during object initialization

@lgtm-com
Copy link

lgtm-com bot commented Mar 15, 2021

This pull request introduces 3 alerts and fixes 2 when merging 8682834 into ceb88c7 - view on LGTM.com

new alerts:

  • 3 for Unused import

fixed alerts:

  • 1 for Conflicting attributes in base classes
  • 1 for Missing call to `__init__` during object initialization

alonre24
alonre24 previously approved these changes Mar 15, 2021
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.0% 3.0% Duplication

@hhsecond hhsecond merged commit c0c7bb5 into master Mar 16, 2021
@hhsecond hhsecond deleted the sherin/restructuring branch March 16, 2021 05:30
@lgtm-com
Copy link

lgtm-com bot commented Mar 16, 2021

This pull request introduces 3 alerts and fixes 2 when merging 6489884 into ceb88c7 - view on LGTM.com

new alerts:

  • 3 for Unused import

fixed alerts:

  • 1 for Conflicting attributes in base classes
  • 1 for Missing call to `__init__` during object initialization

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants