Fix DAGRUN with no LOAD or PERSIST #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a side-note: tests will be failing until RedisAI/redis-inference-optimization#449 is merged |
|
UPDATE: RedisAI/redis-inference-optimization#449 has been merged |
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
=======================================
Coverage 97.10% 97.10%
=======================================
Files 6 6
Lines 656 656
=======================================
Hits 637 637
Misses 19 19
Continue to review full report at Codecov.
|
hhsecond
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most recent
AI.DAGRUNimplementation has become less tolerant with respect to syntax. Specifically, it now returns an error if the command separator|>is not specified afterAI.DAGRUNwhen noLOADorPERSISTare specified.This PR makes sure the separator is always added. It also wraps a test that was supposed to fail but up until #449 it wasn't failing.