-
Notifications
You must be signed in to change notification settings - Fork 5.1k
[component][at_socket] udp一个socket跟多个地址通讯bug修复、DNS加锁防止多线程错乱、实现at_geth… #9403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ostbyname_r、稳定性优化
测试内容ec800创建两个tcp客户端连接到电脑进行echo测试 测试截图4g流量消耗不起,测试数据量很低 测试代码写的很随意请见谅,能测试功能就行
|
mysterywolf
reviewed
Sep 7, 2024
if (device->class->socket_ops->at_domain_resolve(name, ipstr) < 0) | ||
{ | ||
return RT_NULL; | ||
rt_mutex_release(at_dlock); | ||
return -2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-2 表示什么意思?
mysterywolf
requested changes
Sep 7, 2024
@@ -1345,62 +1384,104 @@ static uint32_t ipstr_to_u32(char *ipstr) | |||
return *(uint32_t *) ipBytes; | |||
} | |||
|
|||
struct hostent *at_gethostbyname(const char *name) | |||
static int gethostbyname_by_device(const char *name, ip_addr_t *addr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
需要对这个函数的返回值增加注释说明
mysterywolf
approved these changes
Sep 9, 2024
This was referenced Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ostbyname_r、稳定性优化
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up