Skip to content

feat: arm64: generic implementation of vector irq #9336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

polarvid
Copy link
Contributor

@polarvid polarvid commented Aug 23, 2024

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

This patch generalize the irq handling on up/mp system by adding the rt_hw_irq_exit() & rt_hw_vector_irq_sched() API.

Nohted that there's barely NO changes on logical behaviour of the IRQ handling, and this is only to remove the redundant part.

你的解决方案是什么 (what is your solution)

Changes:

  • Added rt_hw_irq_exit() and rt_hw_vector_irq_sched() APIs for unified IRQ management.
  • Refactored assembly code for both UP and MP systems to use the new IRQ handling flow.
  • Removed redundant code and optimized exception handling paths.

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

This patch generalize the irq handling on up/mp system by adding the
`rt_hw_irq_exit()` & `rt_hw_vector_irq_sched()` API.

Changes:
- Added `rt_hw_irq_exit()` and `rt_hw_vector_irq_sched()` APIs for unified IRQ management.
- Refactored assembly code for both UP and MP systems to use the new IRQ handling flow.
- Removed redundant code and optimized exception handling paths.

Signed-off-by: Shell <[email protected]>
@polarvid polarvid changed the title feat: overall implementation of vector irq feat: arm64: generic implementation of vector irq Aug 23, 2024
@polarvid polarvid added the Arch: ARM/AArch64 BSP related with arm label Aug 23, 2024
@polarvid polarvid marked this pull request as ready for review August 23, 2024 03:54
@polarvid polarvid added the +1 Agree +1 label Aug 26, 2024
@mysterywolf mysterywolf merged commit fd496e4 into RT-Thread:master Aug 27, 2024
44 checks passed
rcitach pushed a commit to rcitach/rt-thread that referenced this pull request Nov 1, 2024
feat: overall implementation of vector irq

This patch generalize the irq handling on up/mp system by adding the
`rt_hw_irq_exit()` & `rt_hw_vector_irq_sched()` API.

Changes:
- Added `rt_hw_irq_exit()` and `rt_hw_vector_irq_sched()` APIs for unified IRQ management.
- Refactored assembly code for both UP and MP systems to use the new IRQ handling flow.
- Removed redundant code and optimized exception handling paths.

Signed-off-by: Shell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arch: ARM/AArch64 BSP related with arm +1 Agree +1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants