fixup: kconfiglib error on vscode console #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the vscode terminal on remote server, there is a chance that the client language is not identical to server. And hence the language required may not be supported by server environment. Finally, we will see an exception occurred with kconfiglib. To fix this issue, this patch will check if the LANG is supported. And set a fall back option if not. See RT-Thread/rt-thread#8843. Signed-off-by: Shell <[email protected]>
mysterywolf
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixup: kconfiglib exception on vscode terminal
For the vscode terminal on remote server,
there is a chance that the client language
is not identical to server. And hence the
language required may not be supported
by server environment. Finally,
we will see an exception occurred with
kconfiglib.
To fix this issue, this patch will check if
the LANG is supported. And set a fall
back option if not.
See RT-Thread/rt-thread#8843.