Skip to content

[vi-mode] Support diw command #2057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
springcomp opened this issue Dec 18, 2020 · 0 comments · Fixed by #2059
Closed

[vi-mode] Support diw command #2057

springcomp opened this issue Dec 18, 2020 · 0 comments · Fixed by #2059
Labels
Issue-Enhancement It's a feature request. Issue-Triaged It indicates an issue was triaged Resolution-Fixed

Comments

@springcomp
Copy link
Contributor

Description of the new feature/enhancement

As alluded to in #584, PSRL should support vim "text-objects".
Consider supporting the diw command to delete inner words.

Proposed technical implementation details (optional)

I think a new Chord dispatch table must be introduced because currently, PSRL cannot handle 3-letter commands.
Most of the implementation from ProcessOneKey can be reused and refactored in common methods.
@springcomp springcomp added the Issue-Enhancement It's a feature request. label Dec 18, 2020
@ghost ghost added the Needs-Triage 🔍 It's a new issue that core contributor team needs to triage. label Dec 18, 2020
@springcomp springcomp mentioned this issue Dec 18, 2020
Merged
6 tasks
daxian-dbw added a commit to springcomp/PSReadLine that referenced this issue Feb 10, 2021
@daxian-dbw
Merge branch 'master' into PowerShell#2057
5bd15b1
@theJasonHelmick theJasonHelmick added Issue-Triaged It indicates an issue was triaged and removed Needs-Triage 🔍 It's a new issue that core contributor team needs to triage. labels Apr 6, 2021
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR A PR is opened targeting the issue label Aug 14, 2023
@daxian-dbw daxian-dbw added Resolution-Fixed and removed In-PR A PR is opened targeting the issue labels Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Enhancement It's a feature request. Issue-Triaged It indicates an issue was triaged Resolution-Fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[vi-mode] Supports 'diw' text-object command. springcomp/PSReadLine
3 participants
@daxian-dbw @springcomp @theJasonHelmick