Skip to content

Windows: Image _scaler engine performance regression #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
PierreRaybaut opened this issue Sep 20, 2024 · 0 comments
Closed

Windows: Image _scaler engine performance regression #23

PierreRaybaut opened this issue Sep 20, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@PierreRaybaut
Copy link
Contributor

PierreRaybaut commented Sep 20, 2024 •
edited
Loading

This issue concerns the image C++ scaling engine.
The anti-aliasing feature is very slow on recent builds of PlotPy.

This affects:

  • PlotPy V2
  • The latest version of guiqwt in which no change has been made to the scaling engine for a long time

This does not affect:

  • OS other than Windows (e.g. Linux)
  • Older builds of guiqwt based on Visual Studio 2008

This has been identified as a regression due to the compiler itself (MSVC).
Changes need to be made to optimize the compilation.
@PierreRaybaut PierreRaybaut added the bug Something isn't working label Sep 20, 2024
PierreRaybaut added a commit that referenced this issue Oct 1, 2024
@PierreRaybaut
Fix scaler engine performance regression on Windows: compiling with `…
a859639 
…/fp:fast` option

Fix Windows: Image `_scaler` engine performance regression  #23

(cherry picked from commit db88b70)
(cherry picked from commit ec6c8c4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PierreRaybaut