Skip to content

Executing test file leaves temporary file #23223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: blead
Choose a base branch
from

Conversation

jkeenan
Copy link
Contributor

@jkeenan jkeenan commented Apr 23, 2025

Executing this test file leaves a temporary file in /tmp.

File::Temp::tempfile() takes 'UNLINK'.
('CLEANUP' is associated with File::Temp::tempdir().)

As noted by Sevan Janiyn, this has already been fixed upstream, but a new CPAN release of Encode has not yet been issued.

Fixes: #23221

File::Temp::tempfile() takes 'UNLINK'.
('CLEANUP' is associated with File::Temp::tempdir().)

As noted by Sevan Janiyn, this has already been fixed upstream, but a
new CPAN release of Encode has not yet been issued.

Fixes: Perl#23221
@jkeenan
Copy link
Contributor Author

jkeenan commented Apr 23, 2025

PSC: Is this change in a test file eligible for merge into blead during code freeze?

@jkeenan jkeenan changed the title Executing this test file leaves a temporary file in /tmp. Executing test file leaves temporary file Apr 23, 2025
@Leont
Copy link
Contributor

Leont commented Apr 24, 2025

The file in under cpan/, so this should be fixed upstream instead (and then later we sync it in)

@jkeenan jkeenan added the do not merge Don't merge this PR, at least for now label Apr 24, 2025
@ap
Copy link
Contributor

ap commented Apr 24, 2025

PSC: Is this change in a test file eligible for merge into blead during code freeze?

Yes. We hope @dankogai ships this patch upstream soon, and assuming the likely case that there are no new changes included in the release that would need additional assessment, you are at that point free to just go ahead and sync it in from CPAN.

(Btw @-addressing this to us individually will get GitHub to send us notifications, which will better get our attention.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Don't merge this PR, at least for now
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cpan/Encode/t/Unicode_trailing_nul.t leaves temp files behind
3 participants