[frontend] fix selector #3023
Open
[frontend] fix selector #3023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/current #3023 +/- ##
==================================================
Coverage 41.20% 41.20%
Complexity 2286 2286
==================================================
Files 682 682
Lines 20937 20937
Branches 1424 1424
==================================================
Hits 8627 8627
Misses 11824 11824
Partials 486 486 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Bugs:
|
|
To check if this PR resolves the following issues:
Thank you! |
| const useStyles = makeStyles()(() => ({ itemHead: { textTransform: 'uppercase' } })); | ||
| const useStyles = makeStyles()(() => ({ | ||
| itemHead: { textTransform: 'uppercase' }, | ||
| item: { height: 50 }, |
There was a problem hiding this comment.
On prerealease :
On my branch :
Others screens where you canclick on the line :
| @@ -815,13 +815,13 @@ ToolBar.propTypes = { | |||
|
|
|||
| const select = (state, ownProps) => { | |||
| const helper = storeHelper(state); | |||
| const endpoints = helper.getEndpoints() | |||
| const endpoints = helper.getEndpoints().toJS() | |||
There was a problem hiding this comment.
In these .js files, getting data from the store is done with the connect function from react redux so unlike useHelper I can not add an invisble layer of toJS conversion
|
guillaumejparis
force-pushed
the
issue/2793-3
branch
from
d2ed391 to
500730b
Compare
|
Yes nice catch for the players one @RomuDeuxfois @savacano28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...