Make `workspace.checkThirdParty` a string enum #2354

9999years · 2023-09-30T22:25:11Z

This lets you skip the "apply third party library to workspace configuration" prompt.

The value of Lua.workspace.checkThirdParty can now be one of:

Ask (ask every time; this is equivalent to true)
Apply (always apply third-party libraries and set the workspace
configuration)
ApplyInMemory (always apply third-party libraries but don't set the
workspace configuration)
Disable (don't ask and don't apply; this is equivalent to false)

Backwards compatibility with the old boolean configuration values is maintained; true is treated as Ask and false is treated as Disable.

I need some help translating the Taiwanese, Mandarin, and Portugese, but I copied the English in there as a standin -- presumably it's better to have some documentation in the wrong language which can be machine-translated than to have missing information.

I've built and tested this on my machine.

sumneko · 2023-10-07T02:26:59Z

To translate, please modify the file in the locale directory (only need to modify one language file), and then execute the locale and build-doc debugger tasks.

sumneko · 2023-10-10T07:30:36Z

locale/en-us/script.lua

Do not modify the file format.

Oops, sorry, I have my editor configured to format-on-save with stylua.

9999years · 2023-10-10T20:30:36Z

How do I execute the build-doc debugger task? I can't seem to run it with lua or luajit:

$ luajit tools/build-doc.lua
luajit: tools/build-doc.lua:3: module 'bee.filesystem' not found:

sumneko · 2023-10-11T02:50:54Z

Use "./bin/lua-language-server" tools/locale.lua and "./bin/lua-language-server" tools/locale.lua

9999years · 2023-10-11T20:39:58Z

Thanks! I ran the locale and debugger tasks.

9999years · 2023-10-11T20:41:02Z

locale/pt-br/meta.lua

@@ -523,7 +523,7 @@ math.maxinteger['>5.3']     =
 'Retorna o valor máximo para um inteiro.'
 math.min                    =
 'Retorna o argumento com o valor mínimo de acordo com o operador `<`.'
-math.mixinteger['>5.3']     =


I think this was a typo, it was making the locale script crash.

I have resolved it, please pull latest commits.

Thanks! Rebased, the diff looks a lot cleaner now.

This lets you skip the "apply third party library to workspace configuration" prompt.

sumneko · 2023-10-19T07:12:16Z

Thank you!

…spam As suggested here: - https://smarttech101.com/nvim-lsp-configure-language-servers-shortcuts-highlights/ > If you don’t know what LÖVE/ Luv, and Luassert are, chances are you > don’t need them. So, disable them permanently Apparently they are a game engine and an assertion library, respectively. Note that lua-language-server only a few days ago changed `checkThirdParty` from a boolean to a string enum in: - LuaLS/lua-language-server#2354 but backwards compatibility is maintained (`false` should be equivalent to `"Disable"`), so I'm going with `false` to have this work in as many places as possible.

nfwyst · 2023-11-07T14:51:51Z

true/false not working

schardev · 2023-11-07T15:18:37Z

true/false not working

Yeah. Should've kept it as backwards compatible instead of breaking current setups.

9999years · 2023-11-07T17:11:25Z

@nfwyst @schardev Hmm, I intended to keep this backwards compatible:

lua-language-server/script/library.lua

Lines 611 to 617 in 3bbc8dd

    
           local checkThirdParty = config.get(uri, 'Lua.workspace.checkThirdParty') 
        
           -- Backwards compatability: `checkThirdParty` used to be a boolean. 
        
           if not checkThirdParty or checkThirdParty == 'Disable' then 
        
               return 
        
           elseif checkThirdParty == true then 
        
               checkThirdParty = 'Ask' 
        
           end

I think the issue is that the config value is now defined as a string:

lua-language-server/script/config/template.lua

Lines 320 to 325 in 5a763b0

    
           ['Lua.workspace.checkThirdParty']       = Type.String >> 'Ask' << { 
        
                                                       'Ask', 
        
                                                       'Apply', 
        
                                                       'ApplyInMemory', 
        
                                                       'Disable', 
        
                                                   },

So when the config is loaded as a boolean, it gets converted to a string:

lua-language-server/script/config/template.lua

Lines 81 to 85 in 5a763b0

    
           register('String', '', function (self, v) 
        
               return type(v) == 'string' 
        
           end, function (self, v) 
        
               return tostring(v) 
        
           end)

I attempted to maintain backwards compatability in LuaLS#2354 but didn't fully understand the config type system.

9999years · 2023-11-07T17:17:13Z

Attempted fix in #2406 but I haven't tested it yet.

See LuaLS/lua-language-server#2354

@pysan3

I attempted to maintain backwards compatability in LuaLS#2354 and LuaLS#2406 but didn't fully understand the config type system. This approach uses `Type.Or` and I even tested it to confirm that it works! Thanks to @pysan3 for pointing out how a default would be used for invalid types and to @sumneko for pointing out `Type.Or`.

sumneko reviewed Oct 10, 2023

View reviewed changes

9999years force-pushed the dont-ask-third-party branch from 1ab45a7 to 2b21dbe Compare October 10, 2023 20:36

9999years commented Oct 11, 2023

View reviewed changes

9999years added 2 commits October 18, 2023 10:00

Make workspace.checkThirdParty a string enum

5f7b0a3

This lets you skip the "apply third party library to workspace configuration" prompt.

Update doc and locale

3bbc8dd

9999years force-pushed the dont-ask-third-party branch from c0333c6 to 3bbc8dd Compare October 18, 2023 17:01

sumneko merged commit 13aebe5 into LuaLS:master Oct 19, 2023

9999years deleted the dont-ask-third-party branch November 7, 2023 17:11

9999years added a commit to 9999years/lua-language-server that referenced this pull request Nov 7, 2023

Fix backwards compatability with Lua.workspace.checkThirdParty

13a24ee

I attempted to maintain backwards compatability in LuaLS#2354 but didn't fully understand the config type system.

9999years mentioned this pull request Nov 7, 2023

Fix backwards compatability with Lua.workspace.checkThirdParty #2406

Merged

pysan3 mentioned this pull request Nov 8, 2023

feature: field type has changed in lua_ls config folke/neoconf.nvim#47

Closed

1 task

minghongx added a commit to minghongx/nvim that referenced this pull request Nov 8, 2023

https://github.com./LuaLS/lua-language-server/pull/2354

4035024

minghongx added a commit to minghongx/nvim that referenced this pull request Nov 8, 2023

LuaLS/lua-language-server#2354

87aae2b

Julian added a commit to Julian/dotfiles that referenced this pull request Nov 9, 2023

Staaaaahhhhhp again.

3da5e21

See LuaLS/lua-language-server#2354

9999years mentioned this pull request Nov 9, 2023

Fix backwards compatability with Lua.workspace.checkThirdParty (take 2!) #2409

Merged

carsakiller mentioned this pull request Nov 20, 2023

can't auto detect love2d project (3.71 is OK, 3.7.2 and 3.7.3 are broken). #2419

Open

justarandomgeek mentioned this pull request Nov 28, 2023

Sumneko don't do Lua diagnostics correctly. justarandomgeek/vscode-factoriomod-debug#102

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make `workspace.checkThirdParty` a string enum #2354

Make `workspace.checkThirdParty` a string enum #2354

9999years commented Sep 30, 2023 •

edited

Loading

sumneko commented Oct 7, 2023

sumneko Oct 10, 2023

9999years Oct 10, 2023

9999years commented Oct 10, 2023

sumneko commented Oct 11, 2023 •

edited

Loading

9999years commented Oct 11, 2023

9999years Oct 11, 2023

sumneko Oct 18, 2023

9999years Oct 18, 2023

sumneko commented Oct 19, 2023

nfwyst commented Nov 7, 2023

schardev commented Nov 7, 2023

9999years commented Nov 7, 2023

9999years commented Nov 7, 2023

Make workspace.checkThirdParty a string enum #2354

Make workspace.checkThirdParty a string enum #2354

Conversation

9999years commented Sep 30, 2023 • edited Loading

sumneko commented Oct 7, 2023

sumneko Oct 10, 2023

Choose a reason for hiding this comment

9999years Oct 10, 2023

Choose a reason for hiding this comment

9999years commented Oct 10, 2023

sumneko commented Oct 11, 2023 • edited Loading

9999years commented Oct 11, 2023

9999years Oct 11, 2023

Choose a reason for hiding this comment

sumneko Oct 18, 2023

Choose a reason for hiding this comment

9999years Oct 18, 2023

Choose a reason for hiding this comment

sumneko commented Oct 19, 2023

nfwyst commented Nov 7, 2023

schardev commented Nov 7, 2023

9999years commented Nov 7, 2023

9999years commented Nov 7, 2023

Make `workspace.checkThirdParty` a string enum #2354

Make `workspace.checkThirdParty` a string enum #2354

9999years commented Sep 30, 2023 •

edited

Loading

sumneko commented Oct 11, 2023 •

edited

Loading