fix: pathStrict should also look for strict path uris in workspace libraries #1592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folke
force-pushed
the
pathStrict_fix
branch
from
4600eb3 to
e4f80b9
Compare
|
Thank you! |
|
@sumneko any chance we could get a new release soon? I have a bunch of changes to lua-dev.nvim that I want to release, but I need the |
|
It takes a long time in plan, but if you are in a hurry, I can publish a small version first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ebabling
pathStrict, lua-language-server properly lists completion for require paths, but can't actually resolve therequireif it's a strict path from a library.This PR fixes that.
Any file where the tail mathes with a library file and where the relative path in the library is
/, should be included when pathStrict is enabled.