Skip to content

Delete lock interface implementation from UmfpackLU #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fredrikekre
Copy link
Member

No description provided.

Copy link

codecov bot commented Apr 24, 2025

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.18%. Comparing base (d050b1b) to head (9063047).

Files with missing lines Patch % Lines
src/solvers/umfpack.jl 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #617      +/-   ##
==========================================
+ Coverage   84.10%   84.18%   +0.07%     
==========================================
  Files          12       12              
  Lines        9188     9179       -9     
==========================================
- Hits         7728     7727       -1     
+ Misses       1460     1452       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ViralBShah ViralBShah added backport 1.10 backport 1.12 Change should be backported to release-1.12 labels Apr 24, 2025
@SobhanMP
Copy link
Member

I'm not critical of the patch, but why? IMHO, it's fair to warn people that they are waiting for locks to do sparse operations.

@fredrikekre
Copy link
Member Author

The motivation wasn't really to remove the warning but rather that it is kind of weird that a struct UmfpackLU is lockable, it isn't an AbstractLock for example.

Regarding the warning, since it isn't really actionable by the user, and safe to ignore, it seems kind of pointless?

@ViralBShah
Copy link
Member

I think it would make sense to document it rather than give a warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.10 backport 1.12 Change should be backported to release-1.12
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants