Primitives in separate folder #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @SimonDanisch could you please take a look at this? Thanks. |
evetion
reviewed
Sep 7, 2020
There was a problem hiding this comment.
Appreciate the effort to structure a codebase! Some remarks:
- Fix the file ending (EOF) with a blank line everywhere (didn't comment on all cases).
- The rest are just thoughts, maybe @SimonDanisch can decide on those.
src/GeometryBasics.jl
Outdated
| @@ -8,11 +8,11 @@ module GeometryBasics | |||
| include("fixed_arrays.jl") | |||
| include("offsetintegers.jl") | |||
| include("basic_types.jl") | |||
| include("primitives.jl") | |||
| include("interfaces.jl") | |||
| include("metadata.jl") | |||
| include("viewtypes.jl") | |||
| include("geometry_primitives.jl") | |||
There was a problem hiding this comment.
Should this file also be moved, or be renamed?
There was a problem hiding this comment.
I agree. Appreciate if anyone can suggest a better name. By reading the contents I couldn't figure out a good name.
|
I've incorporated @evetion suggestions. This PR is ready for review. |
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a first attempt to organize the codebase before contributing actual functionality. I just moved code related to primitives to a single place. Appreciate if you can review.