-
-
Notifications
You must be signed in to change notification settings - Fork 55
Bounding box API #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
That'd be kind of cool! |
Wouldn't it make sense to inherit the element type of the object inside the bounding box? What is the use case you have in mind where the bounding box will have a different element type? By element type you mean coordinate type, correct? Also, I think it would still be easy to use the |
Yeah, it's not a big thing ;) Inheriting element type seems fine |
Fixed in branch |
First let me say that the new documentation is really helpful. I am adding GeometryBasics.jl as a dependency in GeoStats.jl soon given that things are getting in place nicely here.
I've noticed that the boundingboxes.jl file contains axis-aligned bounding box algorithms for the different primitives and geometries. May I submit a PR replacing the
Rect
constructors by an actualboundbox
function to be exported by the package? This way we separate the algorithm of bounding box from the actual constructor of the rectangle primitive. In the future, we could have alternative algorithms to theboundbox
like for example convex and concave hullsconvhull
andconchull
.The text was updated successfully, but these errors were encountered: