Downgrade SciPy to fix CI #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shwang once this is merged please merge changes into your PRs and then I'll review once the CI is green |
shwang
reviewed
Dec 18, 2019
| @@ -32,7 +32,7 @@ commands: | |||
| curl -o /root/.mujoco/mjkey.txt ${MUJOCO_KEY} | |||
| md5sum /root/.mujoco/mjkey.txt | |||
| # Only create venv if it's not been restored from cache | |||
| [[ -d /venv ]] || USE_MPI=True ./ci/build_venv.sh /venv | |||
| [[ -d /venv ]] || ./ci/build_venv.sh /venv | |||
There was a problem hiding this comment.
Did you mean to also remove USE_MPI=True? Not sure what this has to do with scipy or the issue you posted
There was a problem hiding this comment.
it's dead code, we do not ever install mpi4py now. But I should mention it in the PR.
Codecov Report
@@ Coverage Diff @@
## master #139 +/- ##
==========================================
- Coverage 85.45% 84.68% -0.77%
==========================================
Files 59 59
Lines 4001 3958 -43
==========================================
- Hits 3419 3352 -67
- Misses 582 606 +24
Continue to review full report at Codecov.
|
shwang
approved these changes
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also saw an error in https://circleci.com/gh/HumanCompatibleAI/imitation/185#tests/containers/1 that seems to be due to nedbat/coveragepy#881 but I've not been able to reproduce. If this reoccurs we should consider pinning coverage to 4.5.4 until the issue is resolved.