Skip to content

fix(core): Restore original property descriptor on unregister #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jhnns
Copy link

@jhnns jhnns commented Apr 7, 2025

Fixes a potential "Maximum callstack size exceeded" error. The current implementation doesn't cleanup the defineProperty call on the element. For every register() call, a new object descriptor is created which calls the previous one and so on. After a lot of calls of register() and unregister(), the JS engine will finally throw a callstack size error.

Fixes a potential  "Maximum callstack size exceeded" error. The current implementation doesn't cleanup the defineProperty call on the element. For every register() call, a new object descriptor is created which calls the previous one and so on. After a lot of calls of register() and unregister(), the JS engine will finally throw a callstack size error.
@jhnns
Copy link
Author

jhnns commented Apr 7, 2025

We stumbled upon this issue because we use a callback ref to set the ref.current value:

  // Simplified example

  const inputRef = useMask({ /* ... */ });

  return (
    <input
      ref={(element) => {
          inputRef.current = element
      }} 
    />
  );

Since this passes a new function reference for every render, React calls the previous function with null. This causes unregister() and register() to be called via react-input's proxy for every rerender.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant