Updated Dockerfile to match official image #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnsc
force-pushed
the
updated-docker-build
branch
from
8cd65ec to
a1f1a59
Compare
|
@rnsc, oh thanks for contribution. |
|
@rnsc, I created token, created secrets for repo and he can't login in action process.
|
|
@GermanAizek that's weird, login works properly on my repo with the same permissions scope... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Not sure if you're interested, but I wanted to replace the container image I had with 4.4 to a 5.x, but the Dockerfile from your repository was diverging a bit too far from the one of the official Mongo image.
Thus I couldn't do a drop-in replacement.
If this is not desired, I'm ok to close this, I'll keep it in my fork.
It also updates the workflow to build and push images to Docker hub, you need to set two secrets in your repository:
This Docker hub push could be made optional if not desirable.