[Lime] Fix backward compatibility break for handle_exception signature #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Throwables were introduced since PHP 7. http://php.net/manual/en/class.throwable.php Now `lime_test::handle_exception()` method works properly with any `Exception` and `Error` instances. This fix the backward compatibility breaking changes introduce on: 5ea8d65 exception_handler signature changed in php7
|
Closed as fixed on #266 |
alquerci
deleted the
lime-fix-back-compatibility-break-for-exceptionhandler-signature
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throwables were introduced since PHP 7.
http://php.net/manual/en/class.throwable.php
Now
lime_test::handle_exception()method works properly with anyExceptionandErrorinstances.This fix the backward compatibility breaking changes introduce on:
5ea8d65 exception_handler signature changed in php7