-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Adds right-to-left script option. #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,15 +47,13 @@ Below are links to profiles where you can see Readme Typing SVGs in action! | |
[](https://github.com./ShivaSankeerth "Shiva Sankeerth Reddy on GitHub") | ||
[](https://github.com./Tarun-Kamboj "Tarun Kamboj on GitHub") | ||
[](https://github.com./tavignesh "T.A.Vignesh on GitHub") | ||
[](https://github.com./angelofallars "Angelo Fallaria on GitHub") | ||
[](https://github.com./trumbitta "William J. Ghelfi on GitHub") | ||
[](https://github.com./ManoBharathi93 "Mano Bharathi M on GitHub") | ||
[](https://github.com./sudoshivam "Shivam Yadav on GitHub") | ||
[](https://github.com./PROxZIMA "Pratik Pingale on GitHub") | ||
[](https://github.com./VydrOz "Vydr'Oz on GitHub") | ||
[](https://github.com./Carol42 "Caroline Heloíse on GitHub") | ||
[](https://github.com./PriyanshK09 "PriyanshK09 on GitHub") | ||
[](https://github.com./BenjaminMichaelis "BenjaminMichaelis on GitHub") | ||
[](https://github.com./thakurballary "Thakur Ballary on GitHub") | ||
[](https://github.com./nicesapien "NiceSapien on GitHub") | ||
[](https://github.com./manthanank "Manthan Ank on GitHub") | ||
|
@@ -71,7 +69,6 @@ Below are links to profiles where you can see Readme Typing SVGs in action! | |
[](https://github.com./UlisesAlexanderAM "UlisesAlexanderAM on GitHub") | ||
[](https://github.com./SpookyJelly "SpookyJelly on GitHub") | ||
[](https://github.com./cfcife "cfcife on GitHub") | ||
[](https://github.com./majidtdeni666 "majidtdeni666 on GitHub") | ||
[](https://github.com./galexy727 "GalexY727 on GitHub") | ||
[](https://github.com./HectorSaldes "HectorSaldes on GitHub") | ||
[](https://github.com./Ash-codes18 "Ash-codes18 on GitHub") | ||
|
@@ -109,6 +106,7 @@ Below are links to profiles where you can see Readme Typing SVGs in action! | |
[](https://github.com./presentformyfriends "presentformyfriends on Github") | ||
[](https://github.com./Ad7amstein "Ad7amstein on Github") | ||
[](https://github.com./LakshmanKishore "LakshmanKishore on Github") | ||
[](https://github.com./WicCaesar "WicCaesar on Github") | ||
|
||
Feel free to [open a PR](https://github.com./DenverCoder1/readme-typing-svg/issues/21#issue-870549556) and add yours! | ||
|
||
|
@@ -125,6 +123,7 @@ Feel free to [open a PR](https://github.com./DenverCoder1/readme-typing-svg/issue | |
| `background` | Background color of the text (default: `00000000`) | string | Hex code without # (eg. `FEFF4C`) | | ||
| `center` | `true` to center text or `false` for left aligned (default: `false`) | boolean | `true` or `false` | | ||
| `vCenter` | `true` to center vertically or `false`(default) to align above the center | boolean | `true` or `false` | | ||
| `rtl` | `true` to use right-to-left script (Arabic, Hebrew…) (default: `false`) | boolean | `true` or `false` | | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What if instead of having a parameter, it could determine the direction to display the text based on the directionality of the first unidirectional character (eg. if it starts with an English letter it's LTR, if it starts with Arabic it's RTL, standard punctuation is ignored)? Alternatively, it could be determined based on a count comparison of RTL vs LTR characters. By making it automatic, it could simplify configuration and the demo site. Feel free to let me know what you think. |
||
| `multiline` | `true` to wrap lines or `false` to retype on one line (default: `false`) | boolean | `true` or `false` | | ||
| `duration` | Duration of the printing of a single line in milliseconds (default: `5000`) | integer | Any positive number | | ||
| `pause` | Duration of the pause between lines in milliseconds (default: `0`) | integer | Any non-negative number | | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding/removing examples is off topic for this PR and preferably a separate branch/PR should be opened for unrelated changes