Skip to content

feat(aws): AWSX-1388 Remove elb extraction to move them to ingest #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2025
Merged

feat(aws): AWSX-1388 Remove elb extraction to move them to ingest #887

merged 1 commit into from
Feb 14, 2025

Conversation

ViBiOh
Copy link
Contributor

@ViBiOh ViBiOh commented Jan 22, 2025 •
edited
Loading

What does this PR do?

Motivation

Testing Guidelines

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
  • This PR passes the unit tests
  • This PR passes the installation tests (ask a Datadog member to run the tests)

@github-actions github-actions bot added the aws label Jan 22, 2025
@ViBiOh ViBiOh changed the title feat(aws): AWSX-1388 Remove som arn extraction to move them to ingest feat(aws): AWSX-1388 Remove some arn extraction to move them to ingest Jan 22, 2025
@ViBiOh ViBiOh force-pushed the vibioh/AWSX-1388_remove_arn_extraction branch 3 times, most recently from 61f4349 to 3bcc95f Compare February 10, 2025 07:33
@ViBiOh ViBiOh force-pushed the vibioh/AWSX-1388_remove_arn_extraction branch from 3bcc95f to b95ec85 Compare February 12, 2025 07:55
ge0Aja
ge0Aja approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@ge0Aja ge0Aja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I think we need a rebase and an integration test update

@ViBiOh ViBiOh force-pushed the vibioh/AWSX-1388_remove_arn_extraction branch from b95ec85 to d43cbb9 Compare February 14, 2025 12:33
@ViBiOh ViBiOh marked this pull request as ready for review February 14, 2025 13:48
@ViBiOh ViBiOh requested a review from a team as a code owner February 14, 2025 13:48
@ViBiOh ViBiOh changed the title feat(aws): AWSX-1388 Remove some arn extraction to move them to ingest feat(aws): AWSX-1388 Remove elb and step function extraction to move them to ingest Feb 14, 2025
@ViBiOh ViBiOh force-pushed the vibioh/AWSX-1388_remove_arn_extraction branch from f9b67ed to d905b9c Compare February 14, 2025 13:55
@ViBiOh ViBiOh changed the title feat(aws): AWSX-1388 Remove elb and step function extraction to move them to ingest feat(aws): AWSX-1388 Remove elb extraction to move them to ingest Feb 14, 2025
@ViBiOh ViBiOh force-pushed the vibioh/AWSX-1388_remove_arn_extraction branch from 44940f0 to b2fdc9f Compare February 14, 2025 13:58
@ViBiOh ViBiOh merged commit a9bc49a into master Feb 14, 2025
12 checks passed
@ViBiOh ViBiOh deleted the vibioh/AWSX-1388_remove_arn_extraction branch February 14, 2025 15:20
@TrongBYM TrongBYM mentioned this pull request Mar 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ge0Aja ge0Aja ge0Aja approved these changes

Assignees
No one assigned
Labels
aws
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ViBiOh @ge0Aja