Skip to content

Exclude tests and add license file to pip package #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jun 24, 2019

Adding the XML tests files so the tests can be run from a conda build

@ghost
Copy link
Author

ghost commented Jun 24, 2019

Actually thinking about it - we probably want to either exclude the tests module or move it inside the msal module as it currently gets installed as a top level module called "tests" which is probably not what we want.

Copy link
Collaborator

@rayluo rayluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @roederja2 for contributing, again! :-)

Two quick comments below.

@ghost ghost force-pushed the add_additional_files_to_package branch from a0b00ea to 7d3cd05 Compare June 25, 2019 08:56
@ghost ghost changed the title Add XML files from tests and license file to pip package Exclude tests and add license file to pip package Jun 25, 2019
Copy link
Collaborator

@rayluo rayluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @roederja2 ! Now Jann is a second time contributor! 2️⃣ :)

@rayluo rayluo merged commit d133447 into AzureAD:dev Jun 25, 2019
This was referenced Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant