Create README.md for running a JAX workload integrated with elasticity primitives #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebaumann
reviewed
Apr 17, 2025
lukebaumann
reviewed
Apr 17, 2025
lukebaumann
reviewed
Apr 17, 2025
lukebaumann
reviewed
Apr 17, 2025
lukebaumann
reviewed
Apr 17, 2025
lukebaumann
requested changes
Apr 17, 2025
| # 6. Verify by printing steps where training reconfigured from N to N-1 slices and later back to N slices | ||
| # Expect output like: | ||
| # Step: 5, Old Slice Count: 3, New Slice Count: 2 (3 -> 2 slices) |
There was a problem hiding this comment.
This log does not match the logs as they are today.
| good_slice_count = kv[2] | ||
| } | ||
| } | ||
| if (prev_good_slice_count != "" && prev_good_slice_count != good_slice_count) { |
There was a problem hiding this comment.
This seems easily broken. Is there an alternate way to extract this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been verified with 3 v5e-32 slices. I am waiting on AI-Hypercomputer/maxtext#1310 to be merged before we can recommend customers to use the maxtext HEAD to run this e2e workload