Skip to content

version 2 removed some factory methods that were not marked as deprecated. #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stof opened this issue Aug 22, 2019 · 3 comments
Closed

Comments

@stof
Copy link
Contributor

stof commented Aug 22, 2019

Describe the bug
\Jose\Component\Checker\HeaderCheckerManager::create, \Jose\Component\Core\AlgorithmManager::create, \Jose\Component\Checker\HeaderCheckerManager::create and \Jose\Component\Signature\Serializer\JWSSerializerManager::create are gone in 2.x, but they are not marked as deprecated in 1.3.8 and are not listed in the migration guide.

Expected behavior
These methods should be marked as deprecated in a 1.3.x release, and the migration guide should list them.

@stof
Copy link
Contributor Author

stof commented Aug 22, 2019

and the constructors should also become public in a 1.3.x release (otherwise the deprecation cannot be solved)

@Spomky
Copy link
Member

Spomky commented Aug 22, 2019

Hi @stof,

The documentation is now up to date.
Waiting for the end of the tests to merge #201 and tag.

Thank you for this report, I really appreciate.
I close it for now. If you have any comment please continue in #201.

@Spomky Spomky closed this as completed Aug 22, 2019
Copy link
Contributor

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants