Skip to content

Breaking change from #201 not noted as such in changelog #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gsnedders opened this issue May 13, 2019 · 8 comments
Closed

Breaking change from #201 not noted as such in changelog #319

gsnedders opened this issue May 13, 2019 · 8 comments

Comments

@gsnedders
Copy link
Member

#201 breaks idlharness.js, because extAttrs is no longer an array.

@saschanaz
Copy link
Member

Right, but not sure how to fix this for github changelog generator...

BTW, I'd like to restore it as an array to remove the need of painful existence check. The problem is it needs array subclassing, do you think it's okay to do? I somehow am hesitant with no actual reason 🤔 @marcoscaceres

@gsnedders
Copy link
Member Author

gsnedders commented May 13, 2019

Unsurprising, plenty of the trivia changes are breaking, and I keep finding more. Bleh. :/

interface Foo : Bar now has an object for IdlInterface.inheritance, too, and array subclassing won't fix that.

@marcoscaceres
Copy link
Member

BTW, I'd like to restore it as an array to remove the need of painful existence check. The problem is it needs array subclassing, do you think it's okay to do? I somehow am hesitant with no actual reason 🤔 @marcoscaceres

I don't have a strong opinion... if it lessens some pain for @gsnedders on the WPT side, then probably worth doing.

@gsnedders, how bad are the breakages?

@gsnedders
Copy link
Member Author

@marcoscaceres They're all over the place, and without any static types I scarcely know how to find all the places where things have changed to be objects to include tokens etc., but as noted in my previous comment, there are things which have changed from string to an object, and that's a bigger change that can't be so easily be worked around.

@marcoscaceres
Copy link
Member

@gsnedders, sorry, one last bit of info: what's using WebIDL2.js on the WPT side? Is it IDLHarness?

@gsnedders
Copy link
Member Author

@marcoscaceres yes

@saschanaz
Copy link
Member

saschanaz commented May 14, 2019

plenty of the trivia changes are breaking

I recently reverted many of those string-to-object things. Might be easier to jump to the latest version.

@saschanaz
Copy link
Member

saschanaz commented Jul 6, 2019

c8cca88 marked it as a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants