-
-
Notifications
You must be signed in to change notification settings - Fork 64
Breaking change from #201 not noted as such in changelog #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Right, but not sure how to fix this for github changelog generator... BTW, I'd like to restore it as an array to remove the need of painful existence check. The problem is it needs array subclassing, do you think it's okay to do? I somehow am hesitant with no actual reason 🤔 @marcoscaceres |
Unsurprising, plenty of the trivia changes are breaking, and I keep finding more. Bleh. :/
|
I don't have a strong opinion... if it lessens some pain for @gsnedders on the WPT side, then probably worth doing. @gsnedders, how bad are the breakages? |
@marcoscaceres They're all over the place, and without any static types I scarcely know how to find all the places where things have changed to be objects to include tokens etc., but as noted in my previous comment, there are things which have changed from |
@gsnedders, sorry, one last bit of info: what's using WebIDL2.js on the WPT side? Is it IDLHarness? |
@marcoscaceres yes |
I recently reverted many of those string-to-object things. Might be easier to jump to the latest version. |
c8cca88 marked it as a breaking change. |
#201 breaks idlharness.js, because
extAttrs
is no longer an array.The text was updated successfully, but these errors were encountered: