test: options api

Author: posva

tests/firestore/document.spec.ts

@@ -2,20 +2,18 @@ import { mount } from '@vue/test-utils'
 import { describe, expect, it } from 'vitest'
 import { useDocument } from '../../src'
 import {
-  addDoc,
-  collection,
-  doc,
+  doc as originalDoc,
   DocumentData,
   FirestoreError,
   setDoc,
   updateDoc,
 } from 'firebase/firestore'
 import { expectType, setupFirestoreRefs, tds, firestore } from '../utils'
-import { usePendingPromises } from '../../src/vuefire/firestore'
 import { type Ref } from 'vue'
 
 describe('Firestore documents', () => {
-  const { itemRef, listRef, orderedListRef } = setupFirestoreRefs()
+  const { doc } = setupFirestoreRefs()
+  const itemRef = doc()
 
   it('binds a document', async () => {
     const wrapper = mount(
@@ -43,6 +41,7 @@ describe('Firestore documents', () => {
 
   tds(() => {
     const db = firestore
+    const doc = originalDoc
     const itemRef = doc(db, 'todos', '1')
     expectType<Ref<DocumentData | null>>(useDocument(itemRef))
     // @ts-expect-error

tests/firestore/options.spec.ts

@@ -9,9 +9,8 @@ import { type Ref } from 'vue'
 
 const component = defineComponent({ template: 'no' })
 
-describe.skip('Firestore: Options API', () => {
-  const { itemRef, listRef, orderedListRef, collection, doc } =
-    setupFirestoreRefs()
+describe('Firestore: Options API', () => {
+  const { collection, doc } = setupFirestoreRefs()
 
   it('allows customizing $rtdbBind', () => {
     const wrapper = mount(component, {
@@ -50,14 +49,13 @@ describe.skip('Firestore: Options API', () => {
       }
     )
 
-    const items = collection()
-    await items.add({})
+    const itemsRef = collection()
+    await addDoc(itemsRef, {})
 
-    await wrapper.vm.$bind('items', items)
+    await wrapper.vm.$bind('items', itemsRef)
 
     expect(pluginOptions.serialize).toHaveBeenCalledTimes(1)
     expect(pluginOptions.serialize).toHaveBeenCalledWith(
-      // @ts-ignore WTF TS?????
       expect.objectContaining({ data: expect.any(Function) })
     )
     expect(wrapper.vm.items).toEqual([{ foo: 'bar' }])
@@ -79,18 +77,16 @@ describe.skip('Firestore: Options API', () => {
       }
     )
 
-    // @ts-ignore
-    const items: firestore.CollectionReference = db.collection()
-    await items.add({})
+    const itemsRef = collection()
+    await addDoc(itemsRef, {})
 
     const spy = vi.fn(() => ({ bar: 'bar' }))
 
-    await wrapper.vm.$bind('items', items, { serialize: spy })
+    await wrapper.vm.$bind('items', itemsRef, { serialize: spy })
 
     expect(pluginOptions.serialize).not.toHaveBeenCalled()
     expect(spy).toHaveBeenCalledTimes(1)
     expect(spy).toHaveBeenCalledWith(
-      // @ts-ignore WTF TS?????
       expect.objectContaining({ data: expect.any(Function) })
     )
     expect(wrapper.vm.items).toEqual([{ bar: 'bar' }])

tests/utils.ts

@@ -36,24 +36,28 @@ let _id = 0
 export function setupFirestoreRefs() {
   const testId = _id++
   const testsCollection = collection(firestore, `__tests`)
-  const itemRef = doc(testsCollection, `item:${testId}`)
-  const forItemsRef = doc(testsCollection, `forItems:${testId}`)
+  const itemRef = doc(testsCollection)
+  // let firestore generate the id
+  const forItemsRef = doc(testsCollection)
 
   const listRef = collection(forItemsRef, 'list')
   const orderedListRef = firestoreQuery(listRef, orderBy('name'))
 
-  beforeAll(async () => {
+  afterAll(async () => {
     // clean up the tests data
     await Promise.all([
       deleteDoc(itemRef),
       ...[...docsToClean].map((doc) => deleteDoc(doc)),
-      deleteDoc(forItemsRef),
-      ...[...collectionsToClean].map((collection) =>
-        clearCollection(collection)
-      ),
-      clearCollection(listRef),
-      clearCollection(testsCollection),
     ])
+    await Promise.all(
+      [...collectionsToClean].map((collection) => clearCollection(collection))
+    )
+    // must be done after the cleanup of its docs
+    await deleteDoc(forItemsRef),
+      await Promise.all([
+        clearCollection(listRef),
+        clearCollection(testsCollection),
+      ])
   })
 
   // for automatically generated collections