Skip to content

Is Track Switch Off Mode configuration taken into consideration? #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
coreymaher opened this issue Mar 30, 2021 · 4 comments
Closed

Is Track Switch Off Mode configuration taken into consideration? #474

coreymaher opened this issue Mar 30, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@coreymaher
Copy link

Question
The track switch off mode is configurable in the ConnectionOptionsDialog component, but this setting does not appear in the useConnectionOptions hook. Does this mean this configuration is ignored and the default track switch off mode is always used instead?

Additional context
N/A

@coreymaher coreymaher added the question Further information is requested label Mar 30, 2021
@coreymaher coreymaher changed the title Is Track Switch Off Mode configuraiton taken into consideration? Is Track Switch Off Mode configuration taken into consideration? Mar 30, 2021
@timmydoza
Copy link
Contributor

Hey @coreymaher!

I think you are right. It looks like the settings.trackSwitchOffMode property never actually makes its way to the connectionOptions object. Sorry about that! This looks to be a bug to me, so I'll make a ticket and queue it up. I think this fix is easy enough that we should be able to complete it within the next week or two.

Thanks for bringing it to our attention!

@timmydoza timmydoza added bug Something isn't working and removed question Further information is requested labels Mar 31, 2021
@coreymaher
Copy link
Author

Ah, that makes sense. Thanks for looking into this for me!

@olipyskoty
Copy link
Contributor

Hi @coreymaher, this fixed has been merged into the master branch! 🎉 Please let us know if you have any additional questions.

@coreymaher
Copy link
Author

Thanks again @olipyskoty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants