Skip to content

Assign port, http schema automatically based on passed hostname #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

mdesmet
Copy link
Contributor

@mdesmet mdesmet commented Feb 28, 2023

Description

Non-technical explanation

Release notes

( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(*) Release notes are required, with the following suggested text:

* Assign port, http schema automatically based on passed hostname

Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % comment

@mdesmet mdesmet force-pushed the feat/host_parsing branch from 381788b to 474606d Compare March 1, 2023 07:24
@leniartek
Copy link

@hashhar @findepi can one of you merge this please?
This is blocker for dbt-trino release to dbt Cloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants