You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
gives an error ValueError: cannot override reserved HTTP header X-Trino-Role.
We should make the role parameter part of trino.dbapi.connect method.
Describe alternatives you've considered
I can to set role in connection._client_session.role or connection._http_session.headers. Since _client_session property should be an internal abstraction, connection._client_session.role='hive=ROLE{admin}' is ugly and prone to change. We need a proper interface to set such values in connect method.
We should keep release notes and publish critical breaking changes in future.
Are you willing to submit PR?
Yes I am willing to submit a PR!
The text was updated successfully, but these errors were encountered:
Describe the feature
With the recent changes with #200
X-Trino-Role
andX-Trino-Set-Role
are not allowed to be set. The following code:gives an error
ValueError: cannot override reserved HTTP header X-Trino-Role
.We should make the
role
parameter part oftrino.dbapi.connect
method.Describe alternatives you've considered
I can to set
role
inconnection._client_session.role
orconnection._http_session.headers
. Since_client_session
property should be an internal abstraction,connection._client_session.role='hive=ROLE{admin}'
is ugly and prone to change. We need a proper interface to set such values inconnect
method.We should keep release notes and publish critical breaking changes in future.
Are you willing to submit PR?
The text was updated successfully, but these errors were encountered: