Skip to content

Commit a6cf19f

Browse files
committed
minor #1315 Remove useless eslint disabling comments (stof)
This PR was merged into the main branch. Discussion ---------- Remove useless eslint disabling comments Those lines don't report such error. Commits ------- dcfdae1 REmove useless eslint disabling comments
2 parents 4605f80 + dcfdae1 commit a6cf19f

File tree

11 files changed

+12
-12
lines changed

11 files changed

+12
-12
lines changed

lib/loaders/css.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ module.exports = {
5757
};
5858

5959
cssLoaders.push({
60-
loader: require.resolve('postcss-loader'), //eslint-disable-line node/no-unpublished-require
60+
loader: require.resolve('postcss-loader'),
6161
options: applyOptionsCallback(webpackConfig.postCssLoaderOptionsCallback, postCssLoaderOptions)
6262
});
6363
}

lib/loaders/handlebars.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ module.exports = {
2828

2929
return [
3030
{
31-
loader: require.resolve('handlebars-loader'), //eslint-disable-line node/no-unpublished-require
31+
loader: require.resolve('handlebars-loader'),
3232
options: applyOptionsCallback(webpackConfig.handlebarsConfigurationCallback, options)
3333
}
3434
];

lib/loaders/less.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ module.exports = {
3333
return [
3434
...cssLoader.getLoaders(webpackConfig, useCssModules),
3535
{
36-
loader: require.resolve('less-loader'), //eslint-disable-line node/no-unpublished-require
36+
loader: require.resolve('less-loader'),
3737
options: applyOptionsCallback(webpackConfig.lessLoaderOptionsCallback, config)
3838
},
3939
];

lib/loaders/sass.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ module.exports = {
5252
});
5353

5454
sassLoaders.push({
55-
loader: require.resolve('sass-loader'), //eslint-disable-line node/no-unpublished-require
55+
loader: require.resolve('sass-loader'),
5656
options: applyOptionsCallback(webpackConfig.sassLoaderOptionsCallback, config)
5757
});
5858

lib/loaders/stylus.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ module.exports = {
3333
return [
3434
...cssLoader.getLoaders(webpackConfig, useCssModules),
3535
{
36-
loader: require.resolve('stylus-loader'), //eslint-disable-line node/no-unpublished-require
36+
loader: require.resolve('stylus-loader'),
3737
options: applyOptionsCallback(webpackConfig.stylusLoaderOptionsCallback, config)
3838
},
3939
];

lib/loaders/typescript.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ module.exports = {
4040
config.transpileOnly = true;
4141

4242
// add forked ts types plugin to the stack
43-
const forkedTypesPluginUtil = require('../plugins/forked-ts-types'); // eslint-disable-line
43+
const forkedTypesPluginUtil = require('../plugins/forked-ts-types');
4444
forkedTypesPluginUtil(webpackConfig);
4545
}
4646

@@ -54,7 +54,7 @@ module.exports = {
5454
let loaders = babelLoader.getLoaders(webpackConfig);
5555
return loaders.concat([
5656
{
57-
loader: require.resolve('ts-loader'), //eslint-disable-line node/no-unpublished-require
57+
loader: require.resolve('ts-loader'),
5858
// @see https://github.com./TypeStrong/ts-loader/blob/master/README.md#available-options
5959
options: config
6060
}

lib/loaders/vue.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ module.exports = {
3030

3131
return [
3232
{
33-
loader: require.resolve('vue-loader'), //eslint-disable-line node/no-unpublished-require
33+
loader: require.resolve('vue-loader'),
3434
options: applyOptionsCallback(webpackConfig.vueLoaderOptionsCallback, options)
3535
}
3636
];

lib/plugins/notifier.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ module.exports = function(plugins, webpackConfig) {
3333
title: 'Webpack Encore'
3434
};
3535

36-
const WebpackNotifier = require('webpack-notifier'); // eslint-disable-line
36+
const WebpackNotifier = require('webpack-notifier');
3737
plugins.push({
3838
plugin: new WebpackNotifier(
3939
applyOptionsCallback(webpackConfig.notifierPluginOptionsCallback, notifierPluginOptions)

lib/plugins/vue.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ module.exports = function(plugins, webpackConfig) {
2525
return;
2626
}
2727

28-
const { VueLoaderPlugin } = require('vue-loader'); // eslint-disable-line node/no-unpublished-require
28+
const { VueLoaderPlugin } = require('vue-loader');
2929

3030
plugins.push({
3131
plugin: new VueLoaderPlugin(),

lib/webpack/copy-files-loader.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ module.exports.default = function loader(source) {
8484
}
8585
});
8686

87-
const fileLoader = require('file-loader'); // eslint-disable-line node/no-unpublished-require
87+
const fileLoader = require('file-loader');
8888

8989
// If everything is OK, let the file-loader do the copy
9090
return fileLoader.bind(this)(source);

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"test": "yarn run test:main && yarn run test:persistent-cache",
88
"test:main": "mocha --reporter spec test --recursive --ignore test/persistent-cache/*",
99
"test:persistent-cache": "node run-persistent-tests",
10-
"lint": "eslint lib test index.js .eslintrc.js",
10+
"lint": "eslint lib test index.js .eslintrc.js --report-unused-disable-directives",
1111
"travis:lint": "yarn run lint"
1212
},
1313
"bin": {

0 commit comments

Comments
 (0)