Revert "[fix] set platform to neutral when calling esbuild" (#8122)

This reverts commit ee7cd45.

Reverts #8083. Turns out this was a mistake, since it breaks packages like cross-fetch which assume that if you're not resolving browser modules, you want the Node version instead.

Since we bundle esm-env, the original reason for #8083 no longer applies.

Author: Rich-Harris

.changeset/smooth-pianos-kiss.md

@@ -0,0 +1,8 @@
+---
+'@sveltejs/adapter-cloudflare': patch
+'@sveltejs/adapter-cloudflare-workers': patch
+'@sveltejs/adapter-netlify': patch
+'@sveltejs/adapter-vercel': patch
+---
+
+[fix] revert platform change from browser to neutral

packages/adapter-cloudflare-workers/index.js

@@ -62,15 +62,15 @@ export default function ({ config = 'wrangler.toml' } = {}) {
 			);
 
 			await esbuild.build({
-				platform: 'neutral',
-				mainFields: ['module', 'main'],
-				conditions: ['worker'],
+				platform: 'browser',
+				conditions: ['worker', 'browser'],
 				sourcemap: 'linked',
 				target: 'es2020',
 				entryPoints: [`${tmp}/entry.js`],
 				outfile: main,
 				bundle: true,
-				external: ['__STATIC_CONTENT_MANIFEST']
+				external: ['__STATIC_CONTENT_MANIFEST'],
+				format: 'esm'
 			});
 
 			builder.log.minor('Copying assets...');

packages/adapter-cloudflare/index.js

@@ -54,14 +54,14 @@ export default function () {
 			});
 
 			await esbuild.build({
-				platform: 'neutral',
-				mainFields: ['module', 'main'],
-				conditions: ['worker'],
+				platform: 'browser',
+				conditions: ['worker', 'browser'],
 				sourcemap: 'linked',
 				target: 'es2020',
 				entryPoints: [`${tmp}/_worker.js`],
 				outfile: `${dest}/_worker.js`,
 				allowOverwrite: true,
+				format: 'esm',
 				bundle: true
 			});
 		}

packages/adapter-netlify/index.js

@@ -129,11 +129,11 @@ async function generate_edge_functions({ builder }) {
 	);
 
 	await esbuild.build({
-		platform: 'neutral',
-		mainFields: ['module', 'main'],
 		entryPoints: [`${tmp}/entry.js`],
 		outfile: '.netlify/edge-functions/render.js',
 		bundle: true,
+		format: 'esm',
+		platform: 'browser',
 		sourcemap: 'linked',
 		target: 'es2020'
 	});

packages/adapter-vercel/index.js

@@ -122,12 +122,12 @@ const plugin = function ({ external = [], edge, split } = {}) {
 				);
 
 				await esbuild.build({
-					platform: 'neutral',
-					mainFields: ['module', 'main'],
 					entryPoints: [`${tmp}/edge.js`],
 					outfile: `${dirs.functions}/${name}.func/index.js`,
 					target: 'es2020', // TODO verify what the edge runtime supports
 					bundle: true,
+					platform: 'browser',
+					format: 'esm',
 					external,
 					sourcemap: 'linked',
 					banner: { js: 'globalThis.global = globalThis;' }