Skip to content

Re-write diagnostics handler #7630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Aatch opened this issue Jul 6, 2013 · 4 comments
Closed

Re-write diagnostics handler #7630

Aatch opened this issue Jul 6, 2013 · 4 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. I-compiletime Issue: Problems and improvements with respect to compile times.

Comments

@Aatch
Copy link
Contributor

Aatch commented Jul 6, 2013

The current one uses a frankly obscene amount of @-allocation. It needs a major overhaul in order to make it possible to send it between tasks.

@huonw
Copy link
Member

huonw commented Aug 19, 2013

Triage visit: still horrible. I've made a little attempt at this, but I quickly hit various road-blocks (particularly the use of @-closures), so I'm unlikely to continue in the near future.

@steveklabnik
Copy link
Member

I am guessing that this is src/libsyntax/diagnostics/*? It now only uses one Gc<T>.

@huonw
Copy link
Member

huonw commented Aug 12, 2014

@steveklabnik confusingly, it's src/libsyntax/diagnostic.rs; it now doesn't have any @ closures (since they're gone) and doesn't actually use Gc<T> at all either.

@brson
Copy link
Contributor

brson commented Jan 13, 2015

Dupe of #10492

@brson brson closed this as completed Jan 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. I-compiletime Issue: Problems and improvements with respect to compile times.
Projects
None yet
Development

No branches or pull requests

4 participants