Skip to content

Inconsistent warning on get_disjoint_mut #139296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
zirconium-n opened this issue Apr 3, 2025 · 1 comment · May be fixed by #139307
Open

Inconsistent warning on get_disjoint_mut #139296

zirconium-n opened this issue Apr 3, 2025 · 1 comment · May be fixed by #139307
Assignees
@xizheyin
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Comments

@zirconium-n
Copy link
Contributor

zirconium-n commented Apr 3, 2025 •
edited by rustbot
Loading

Location

slice::get_disjoint_mut got a warning about O(n^2) check for overlapping indices, but HashMap::get_disjoint_mut does not.

Summary

I think we should add this warning to HashMap::get_disjoint_mut as well.
@zirconium-n zirconium-n added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Apr 3, 2025
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Apr 3, 2025
@Urgau Urgau added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Apr 3, 2025
@xizheyin
Copy link
Contributor

xizheyin commented Apr 3, 2025

@rustbot claim

@xizheyin xizheyin linked a pull request Apr 3, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xizheyin xizheyin

Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

std: Add performance warnings to HashMap::get_disjoint_mut xizheyin/rust
4 participants
@Urgau @zirconium-n @rustbot @xizheyin