Skip to content

Commit 88fa119

Browse files
borsbors
committed
Auto merge of #127670 - compiler-errors:no-type-length-limit, r=jackh726
Gate the type length limit check behind a nightly flag Effectively disables the type length limit by introducing a `-Zenforce-type-length-limit` which defaults to **`false`**, since making the length limit actually be enforced ended up having a worse fallout than expected. We still keep the code around, but the type length limit attr is now a noop (except for its usage in some diagnostics code?). r? `@lcnr` -- up to you to decide what team consensus we need here since this reverses an FCP decision. Reopens #125460 (if we decide to reopen it or keep it closed) Effectively reverses the decision FCP'd in #125507 Closes #127346
2 parents a241cf1 + 938ed36 commit 88fa119

17 files changed

+54
-58
lines changed

Diff for: ‎compiler/rustc_middle/src/ty/instance.rs

+3-1
Original file line numberDiff line numberDiff line change
@@ -541,7 +541,9 @@ impl<'tcx> Instance<'tcx> {
541541
// which means that rustc basically hangs.
542542
//
543543
// Bail out in these cases to avoid that bad user experience.
544-
if !tcx.type_length_limit().value_within_limit(type_length(args)) {
544+
if tcx.sess.opts.unstable_opts.enforce_type_length_limit
545+
&& !tcx.type_length_limit().value_within_limit(type_length(args))
546+
{
545547
return Ok(None);
546548
}
547549

Diff for: ‎compiler/rustc_session/src/options.rs

+2
Original file line numberDiff line numberDiff line change
@@ -1711,6 +1711,8 @@ options! {
17111711
"emit a section containing stack size metadata (default: no)"),
17121712
emit_thin_lto: bool = (true, parse_bool, [TRACKED],
17131713
"emit the bc module with thin LTO info (default: yes)"),
1714+
enforce_type_length_limit: bool = (false, parse_bool, [TRACKED],
1715+
"enforce the type length limit when monomorphizing instances in codegen"),
17141716
export_executable_symbols: bool = (false, parse_bool, [TRACKED],
17151717
"export symbols from executables, as if they were dynamic libraries"),
17161718
external_clangrt: bool = (false, parse_bool, [UNTRACKED],

Diff for: ‎tests/ui/closures/issue-72408-nested-closures-exponential.rs

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
//@ build-fail
1+
//@ check-pass
22

33
// Closures include captured types twice in a type tree.
44
//
@@ -45,7 +45,6 @@ fn main() {
4545

4646
let f = dup(f);
4747
let f = dup(f);
48-
//~^ ERROR reached the type-length limit
4948
let f = dup(f);
5049
let f = dup(f);
5150
let f = dup(f);

Diff for: ‎tests/ui/closures/issue-72408-nested-closures-exponential.stderr

-10
This file was deleted.

Diff for: ‎tests/ui/codegen/overflow-during-mono.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1+
//~ ERROR overflow evaluating the requirement `{closure@$DIR/overflow-during-mono.rs:13:41: 13:44}: Sized`
12
//@ build-fail
2-
//@ error-pattern: reached the type-length limit while instantiating
33

44
#![recursion_limit = "32"]
55

Diff for: ‎tests/ui/codegen/overflow-during-mono.stderr

+7-4
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,11 @@
1-
error: reached the type-length limit while instantiating `<Filter<Filter<std::array::IntoIter<i32, 11>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, ...> as Iterator>::try_fold::<..., ..., ...>`
2-
--> $SRC_DIR/core/src/iter/adapters/filter.rs:LL:COL
1+
error[E0275]: overflow evaluating the requirement `{closure@$DIR/overflow-during-mono.rs:13:41: 13:44}: Sized`
32
|
4-
= help: consider adding a `#![type_length_limit="20156994"]` attribute to your crate
5-
= note: the full type name has been written to '$TEST_BUILD_DIR/codegen/overflow-during-mono/overflow-during-mono.long-type.txt'
3+
= help: consider increasing the recursion limit by adding a `#![recursion_limit = "64"]` attribute to your crate (`overflow_during_mono`)
4+
= note: required for `Filter<std::array::IntoIter<i32, 11>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>` to implement `Iterator`
5+
= note: 31 redundant requirements hidden
6+
= note: required for `Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<std::array::IntoIter<i32, 11>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>` to implement `Iterator`
7+
= note: required for `Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<Filter<std::array::IntoIter<i32, 11>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>, {closure@$DIR/overflow-during-mono.rs:13:41: 13:44}>` to implement `IntoIterator`
68

79
error: aborting due to 1 previous error
810

11+
For more information about this error, try `rustc --explain E0275`.

Diff for: ‎tests/ui/issues/issue-22638.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ impl C {
4040
pub fn matches<F: Fn()>(&self, f: &F) {
4141
let &C(ref base) = self;
4242
base.matches(&|| {
43-
//~^ ERROR reached the type-length limit
4443
C(base.clone()).matches(f)
4544
})
4645
}
@@ -53,6 +52,7 @@ impl D {
5352
pub fn matches<F: Fn()>(&self, f: &F) {
5453
let &D(ref a) = self;
5554
a.matches(f)
55+
//~^ ERROR reached the recursion limit while instantiating
5656
}
5757
}
5858

Diff for: ‎tests/ui/issues/issue-22638.stderr

+9-8
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
1-
error: reached the type-length limit while instantiating `D::matches::<{closure@$DIR/issue-22638.rs:42:23: 42:25}>`
2-
--> $DIR/issue-22638.rs:42:9
1+
error: reached the recursion limit while instantiating `A::matches::<{closure@$DIR/issue-22638.rs:42:23: 42:25}>`
2+
--> $DIR/issue-22638.rs:54:9
33
|
4-
LL | / base.matches(&|| {
5-
LL | |
6-
LL | | C(base.clone()).matches(f)
7-
LL | | })
8-
| |__________^
4+
LL | a.matches(f)
5+
| ^^^^^^^^^^^^
96
|
10-
= help: consider adding a `#![type_length_limit="30408681"]` attribute to your crate
7+
note: `A::matches` defined here
8+
--> $DIR/issue-22638.rs:13:5
9+
|
10+
LL | pub fn matches<F: Fn()>(&self, f: &F) {
11+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1112

1213
error: aborting due to 1 previous error
1314

Diff for: ‎tests/ui/issues/issue-37311-type-length-limit/issue-37311.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ impl<T> Foo for T {
1515
#[allow(unconditional_recursion)]
1616
fn recurse(&self) {
1717
(self, self).recurse();
18-
//~^ ERROR reached the type-length limit
18+
//~^ ERROR reached the recursion limit while instantiating
1919
}
2020
}
2121

Diff for: ‎tests/ui/issues/issue-37311-type-length-limit/issue-37311.stderr

+6-2
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,14 @@
1-
error: reached the type-length limit while instantiating `<(&(&(..., ...), ...), ...) as Foo>::recurse`
1+
error: reached the recursion limit while instantiating `<(&(&(..., ...), ...), ...) as Foo>::recurse`
22
--> $DIR/issue-37311.rs:17:9
33
|
44
LL | (self, self).recurse();
55
| ^^^^^^^^^^^^^^^^^^^^^^
66
|
7-
= help: consider adding a `#![type_length_limit="33554429"]` attribute to your crate
7+
note: `<T as Foo>::recurse` defined here
8+
--> $DIR/issue-37311.rs:16:5
9+
|
10+
LL | fn recurse(&self) {
11+
| ^^^^^^^^^^^^^^^^^
812
= note: the full type name has been written to '$TEST_BUILD_DIR/issues/issue-37311-type-length-limit/issue-37311/issue-37311.long-type.txt'
913

1014
error: aborting due to 1 previous error

Diff for: ‎tests/ui/iterators/issue-58952-filter-type-length.rs

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
//@ build-fail
2-
//@ error-pattern: reached the type-length limit while instantiating
1+
//@ build-pass
32

43
//! This snippet causes the type length to blowup exponentially,
54
//! so check that we don't accidentally exceed the type length limit.

Diff for: ‎tests/ui/iterators/issue-58952-filter-type-length.stderr

-8
This file was deleted.

Diff for: ‎tests/ui/recursion/issue-83150.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
//~ ERROR overflow evaluating the requirement `Map<&mut std::ops::Range<u8>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>: Iterator`
12
//@ build-fail
23
//@ compile-flags: -Copt-level=0
34
//@ normalize-stderr-test: "long-type-\d+" -> "long-type-hash"
@@ -11,5 +12,4 @@ fn main() {
1112
fn func<T: Iterator<Item = u8>>(iter: &mut T) {
1213
//~^ WARN function cannot return without recursing
1314
func(&mut iter.map(|x| x + 1))
14-
//~^ ERROR reached the type-length limit
1515
}

Diff for: ‎tests/ui/recursion/issue-83150.stderr

+7-8
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
warning: function cannot return without recursing
2-
--> $DIR/issue-83150.rs:11:1
2+
--> $DIR/issue-83150.rs:12:1
33
|
44
LL | fn func<T: Iterator<Item = u8>>(iter: &mut T) {
55
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing
@@ -10,14 +10,13 @@ LL | func(&mut iter.map(|x| x + 1))
1010
= help: a `loop` may express intention better if this is on purpose
1111
= note: `#[warn(unconditional_recursion)]` on by default
1212

13-
error: reached the type-length limit while instantiating `<&mut Map<&mut Map<&mut ..., ...>, ...> as Iterator>::map::<..., ...>`
14-
--> $DIR/issue-83150.rs:13:15
13+
error[E0275]: overflow evaluating the requirement `Map<&mut std::ops::Range<u8>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>: Iterator`
1514
|
16-
LL | func(&mut iter.map(|x| x + 1))
17-
| ^^^^^^^^^^^^^^^^^^^
18-
|
19-
= help: consider adding a `#![type_length_limit="23068663"]` attribute to your crate
20-
= note: the full type name has been written to '$TEST_BUILD_DIR/recursion/issue-83150/issue-83150.long-type.txt'
15+
= help: consider increasing the recursion limit by adding a `#![recursion_limit = "256"]` attribute to your crate (`issue_83150`)
16+
= note: required for `&mut Map<&mut std::ops::Range<u8>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>` to implement `Iterator`
17+
= note: 65 redundant requirements hidden
18+
= note: required for `&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut Map<&mut std::ops::Range<u8>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>, {closure@$DIR/issue-83150.rs:14:24: 14:27}>` to implement `Iterator`
2119

2220
error: aborting due to 1 previous error; 1 warning emitted
2321

22+
For more information about this error, try `rustc --explain E0275`.

Diff for: ‎tests/ui/traits/issue-91949-hangs-on-recursion.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
//~ ERROR overflow evaluating the requirement `<std::iter::Empty<()> as Iterator>::Item == ()`
12
//@ build-fail
23
//@ compile-flags: -Zinline-mir=no
34

@@ -23,7 +24,6 @@ where
2324
T: Iterator<Item = ()>,
2425
{
2526
recurse(IteratorOfWrapped(elements).map(|t| t.0))
26-
//~^ ERROR reached the type-length limit
2727
}
2828

2929
fn main() {

0 commit comments

Comments
 (0)