Merge #28

28: Don't return SyntaxKind from bump r=matklad a=matklad

Author: bors[bot]

src/parser/event_parser/grammar/items.rs

@@ -174,9 +174,7 @@ fn use_item(p: &mut Parser) {
         let la = p.nth(1);
         let m = p.start();
         match (p.current(), la) {
-            (STAR, _) => {
-                p.bump();
-            }
+            (STAR, _) => p.bump(),
             (COLONCOLON, STAR) => {
                 p.bump();
                 p.bump();

src/parser/event_parser/grammar/mod.rs

@@ -21,11 +21,15 @@ fn visibility(p: &mut Parser) {
         p.bump();
         if p.at(L_PAREN) {
             match p.nth(1) {
-                CRATE_KW | SELF_KW | SUPER_KW | IN_KW => {
+                CRATE_KW | SELF_KW | SUPER_KW => {
                     p.bump();
-                    if p.bump() == IN_KW {
-                        paths::use_path(p);
-                    }
+                    p.bump();
+                    p.expect(R_PAREN);
+                }
+                IN_KW => {
+                    p.bump();
+                    p.bump();
+                    paths::use_path(p);
                     p.expect(R_PAREN);
                 }
                 _ => (),

src/parser/event_parser/grammar/paths.rs

@@ -30,12 +30,8 @@ fn path_segment(p: &mut Parser, first: bool) {
         p.eat(COLONCOLON);
     }
     match p.current() {
-        IDENT | SELF_KW | SUPER_KW => {
-            p.bump();
-        }
-        _ => {
-            p.error().message("expected identifier").emit();
-        }
+        IDENT | SELF_KW | SUPER_KW => p.bump(),
+        _ => p.error().message("expected identifier").emit(),
     };
     segment.complete(p, PATH_SEGMENT);
 }

src/parser/event_parser/parser.rs

@@ -151,17 +151,16 @@ impl<'t> Parser<'t> {
         ErrorBuilder::new(self)
     }
 
-    pub(crate) fn bump(&mut self) -> SyntaxKind {
+    pub(crate) fn bump(&mut self) {
         let kind = self.current();
         if kind == EOF {
-            return EOF;
+            return;
         }
         self.pos += 1;
         self.event(Event::Token {
             kind,
             n_raw_tokens: 1,
         });
-        kind
     }
 
     pub(crate) fn nth(&self, n: usize) -> SyntaxKind {