Skip to content

Commit 01a7c0c

Browse files
committed
Ignore broken nightly/system builtins
1 parent 367ba35 commit 01a7c0c

File tree

1 file changed

+13
-3
lines changed

1 file changed

+13
-3
lines changed

testcrate/src/bench.rs

+13-3
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,10 @@ pub fn skip_sys_checks(test_name: &str) -> bool {
1717
"extend_f16_f32",
1818
"trunc_f32_f16",
1919
"trunc_f64_f16",
20-
// FIXME(f16_f128): rounding error
20+
// FIXME(#616): re-enable once fix is in nightly
2121
// <https://github.com./rust-lang/compiler-builtins/issues/616>
22-
"mul_f128",
22+
"mul_f32",
23+
"mul_f64",
2324
];
2425

2526
// FIXME(f16_f128): error on LE ppc64. There are more tests that are cfg-ed out completely
@@ -29,7 +30,12 @@ pub fn skip_sys_checks(test_name: &str) -> bool {
2930

3031
// FIXME(f16_f128): system symbols have incorrect results
3132
// <https://github.com./rust-lang/compiler-builtins/issues/617#issuecomment-2125914639>
32-
const X86_NO_SSE_SKIPPED: &[&str] = &["add_f128", "sub_f128", "powi_f32", "powi_f64"];
33+
const X86_NO_SSE_SKIPPED: &[&str] =
34+
&["add_f128", "sub_f128", "mul_f128", "powi_f32", "powi_f64"];
35+
36+
// FIXME(f16_f128): Incorrect rounding.
37+
// <https://github.com./llvm/llvm-project/issues/91840>
38+
const AARCH64_SKIPPED: &[&str] = &["mul_f128"];
3339

3440
// FIXME(llvm): system symbols have incorrect results on Windows
3541
// <https://github.com./rust-lang/compiler-builtins/issues/617#issuecomment-2121359807>
@@ -61,6 +67,10 @@ pub fn skip_sys_checks(test_name: &str) -> bool {
6167
return true;
6268
}
6369

70+
if cfg!(target_arch = "aarch64") && AARCH64_SKIPPED.contains(&test_name) {
71+
return true;
72+
}
73+
6474
if cfg!(target_family = "windows") && WINDOWS_SKIPPED.contains(&test_name) {
6575
return true;
6676
}

0 commit comments

Comments
 (0)