Skip to content

Implement a generic filters plugin #1577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
4 tasks
christophfroehlich opened this issue Mar 9, 2025 · 10 comments
Open
4 tasks

Implement a generic filters plugin #1577

christophfroehlich opened this issue Mar 9, 2025 · 10 comments

Comments

@christophfroehlich
Copy link
Contributor

The filters package provides a standardized interface for processing data as a sequence of filters. We also have custom filter plugins in the control_toolbox package.

There exists already a blueprint of such a controller from the last years ROSCon workshop:

Necessary steps:

  • Move that to this repository
  • spice it up with some tests (have a look at other controllers here)
  • Advertise the control_filters of control_toolbox in the description
  • Create a follow-up PR in the demos repository to use such a filter for state interfaces of a controller chain.
@CodrAyush
Copy link

@christophfroehlich i want to work over this issue..could you pls help me out in setting up this project

@christophfroehlich
Copy link
Contributor Author

what exactly do you need? maybe you should start with a good-first issue to go through the process once?

@ankurbodhe
Copy link

@christophfroehlich i'm interested to take this issue up and contribute.

@kscottz
Copy link

kscottz commented Mar 18, 2025

@christophfroehlich can you assign this to @ankurbodhe please?

@saikishor
Copy link
Member

Done! :)

@christophfroehlich
Copy link
Contributor Author

@christophfroehlich i'm interested to take this issue up and contribute.

Great! Come back to me if you need advise or intermediate review!

@kscottz
Copy link

kscottz commented Apr 2, 2025

@ankurbodhe how is it going? I haven't see a pull request. Did I miss it?

@ankurbodhe
Copy link

ankurbodhe commented Apr 2, 2025

@kscottz I'm working on it and would have a PR up by 04/08.... let me know this is needed earlier than that

@kscottz
Copy link

kscottz commented Apr 8, 2025

@ankurbodhe friendly ping.

@ankurbodhe
Copy link

ankurbodhe commented Apr 9, 2025

@christophfroehlich @kscottz here is a link to the draft PR: #1634
Would love to get some advise and review on this draft and will finish the rest post that.

Do let me know if there are any issues with the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

5 participants