From d18dc92821a16ef4220611f008367745beeecb14 Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Sat, 11 Jan 2020 18:41:35 +0000 Subject: [PATCH 01/10] add lint action --- .github/workflows/blank.yml | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 .github/workflows/blank.yml diff --git a/.github/workflows/blank.yml b/.github/workflows/blank.yml new file mode 100644 index 00000000000000..89b1b3d8f9cf71 --- /dev/null +++ b/.github/workflows/blank.yml @@ -0,0 +1,17 @@ +name: CI + +on: [push, pull_request] + +jobs: + lint: + + runs-on: ubuntu-latest + + steps: + - uses: actions/checkout@v2 + - name: Use Node.js ${{ matrix.node-version }} + uses: actions/setup-node@v1 + with: + node-version: 10.x + - name: lint + run: NODE=$(which node) make lint From bab8e72ce14ebfb44d79fb5e4b24706d85084ce1 Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Sat, 11 Jan 2020 18:47:43 +0000 Subject: [PATCH 02/10] cc break --- src/node_report.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/src/node_report.cc b/src/node_report.cc index ddeb216c82d6bc..71796377f2eb6d 100644 --- a/src/node_report.cc +++ b/src/node_report.cc @@ -40,6 +40,7 @@ using v8::StackTrace; using v8::String; using v8::V8; using v8::Value; + using v8::Function; // Internal/static function declarations static void WriteNodeReport(Isolate* isolate, From 5e1356cab1235d58162d2b6cec14c5b78d9f8210 Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Sat, 11 Jan 2020 18:57:49 +0000 Subject: [PATCH 03/10] break js --- lib/internal/process/report.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/internal/process/report.js b/lib/internal/process/report.js index 407cc12cb04f76..dd4a5d233e309d 100644 --- a/lib/internal/process/report.js +++ b/lib/internal/process/report.js @@ -105,7 +105,8 @@ function signalHandler(sig) { nr.writeReport(sig, 'Signal', null, ''); } + module.exports = { addSignalHandler, - report + report }; From 3f8aa45fe39d0a7e296776215adb08b88fb300ed Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Sat, 11 Jan 2020 19:06:21 +0000 Subject: [PATCH 04/10] break markdown --- doc/api/report.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/api/report.md b/doc/api/report.md index b39a5286398b2c..2b52e07fc7c787 100644 --- a/doc/api/report.md +++ b/doc/api/report.md @@ -10,7 +10,7 @@ Delivers a JSON-formatted diagnostic summary, written to a file. The report is intended for development, test and production use, to capture -and preserve information for problem determination. It includes JavaScript +and preserve information for problem determination. Note that it includes JavaScript and native stack traces, heap statistics, platform information, resource usage etc. With the report option enabled, diagnostic reports can be triggered on unhandled exceptions, fatal errors and user signals, in addition to @@ -22,7 +22,7 @@ is provided below for reference. ```json { "header": { - "reportVersion": 1, + "reportVersion": 1, "event": "exception", "trigger": "Exception", "filename": "report.20181221.005011.8974.0.001.json", @@ -435,7 +435,7 @@ written. A report can also be triggered via an API call from a JavaScript application: ```js -process.report.writeReport(); +process.report.writeReport( ); ``` This function takes an optional additional argument `filename`, which is @@ -446,7 +446,7 @@ process.report.writeReport('./foo.json'); ``` This function takes an optional additional argument `err` which is an `Error` -object that will be used as the context for the JavaScript stack printed in the +object that will be used as the context for the Javascript stack printed in the report. When using report to handle errors in a callback or an exception handler, this allows the report to include the location of the original error as well as where it was handled. From 7654da39083676f7fc9adc8c6ed1a5fd2876b8e3 Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Sat, 11 Jan 2020 19:39:58 +0000 Subject: [PATCH 05/10] separate linters --- .github/workflows/blank.yml | 31 +++++++++++++++++++++++++++++-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git a/.github/workflows/blank.yml b/.github/workflows/blank.yml index 89b1b3d8f9cf71..e27622a2b62302 100644 --- a/.github/workflows/blank.yml +++ b/.github/workflows/blank.yml @@ -3,10 +3,37 @@ name: CI on: [push, pull_request] jobs: - lint: + lint-addon-docs: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + - name: Use Node.js ${{ matrix.node-version }} + uses: actions/setup-node@v1 + with: + node-version: 10.x + - name: lint + run: NODE=$(which node) make lint-addon-docs + + lint-cpp: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + - name: lint + run: make lint-cpp + lint-docs: runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + - name: Use Node.js ${{ matrix.node-version }} + uses: actions/setup-node@v1 + with: + node-version: 10.x + - name: lint + run: NODE=$(which node) make lint-md + lint-js: + runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - name: Use Node.js ${{ matrix.node-version }} @@ -14,4 +41,4 @@ jobs: with: node-version: 10.x - name: lint - run: NODE=$(which node) make lint + run: NODE=$(which node) make lint-js From f0a125c15989089062b8b326e6ebde6b155cd5de Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Sat, 11 Jan 2020 22:45:41 +0000 Subject: [PATCH 06/10] rename jobs --- .github/workflows/blank.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/blank.yml b/.github/workflows/blank.yml index e27622a2b62302..55b5a4497a5c9b 100644 --- a/.github/workflows/blank.yml +++ b/.github/workflows/blank.yml @@ -3,7 +3,7 @@ name: CI on: [push, pull_request] jobs: - lint-addon-docs: + Lint addon docs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 @@ -14,14 +14,14 @@ jobs: - name: lint run: NODE=$(which node) make lint-addon-docs - lint-cpp: + Lint C++ files: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - name: lint run: make lint-cpp - lint-docs: + Lint docs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 @@ -32,7 +32,7 @@ jobs: - name: lint run: NODE=$(which node) make lint-md - lint-js: + Lint JavaScript files: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 From aed54f9e721f7679f30042320f9c1b4ed95d6618 Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Sat, 11 Jan 2020 22:47:11 +0000 Subject: [PATCH 07/10] fix job names --- .github/workflows/blank.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/blank.yml b/.github/workflows/blank.yml index 55b5a4497a5c9b..336a366ef13e1a 100644 --- a/.github/workflows/blank.yml +++ b/.github/workflows/blank.yml @@ -3,7 +3,7 @@ name: CI on: [push, pull_request] jobs: - Lint addon docs: + Lint_addon_docs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 @@ -14,14 +14,14 @@ jobs: - name: lint run: NODE=$(which node) make lint-addon-docs - Lint C++ files: + Lint_C++_files: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - name: lint run: make lint-cpp - Lint docs: + Lint_docs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 @@ -32,7 +32,7 @@ jobs: - name: lint run: NODE=$(which node) make lint-md - Lint JavaScript files: + Lint_JavaScript_files: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 From 26479a6728929fb42857abf9d7bdf649e532046c Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Sat, 11 Jan 2020 22:48:45 +0000 Subject: [PATCH 08/10] fix job name --- .github/workflows/blank.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/blank.yml b/.github/workflows/blank.yml index 336a366ef13e1a..3eece0061e9e9d 100644 --- a/.github/workflows/blank.yml +++ b/.github/workflows/blank.yml @@ -14,7 +14,7 @@ jobs: - name: lint run: NODE=$(which node) make lint-addon-docs - Lint_C++_files: + Lint_Cpp_files: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 From 34c9ed560dc162f85d69b75b7128246eb4020e40 Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Sun, 12 Jan 2020 00:04:05 +0000 Subject: [PATCH 09/10] Update blank.yml --- .github/workflows/blank.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/blank.yml b/.github/workflows/blank.yml index 3eece0061e9e9d..9b5f9173cff73d 100644 --- a/.github/workflows/blank.yml +++ b/.github/workflows/blank.yml @@ -3,7 +3,7 @@ name: CI on: [push, pull_request] jobs: - Lint_addon_docs: + lint-addon-docs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 @@ -14,14 +14,14 @@ jobs: - name: lint run: NODE=$(which node) make lint-addon-docs - Lint_Cpp_files: + lint-cpp: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - name: lint run: make lint-cpp - Lint_docs: + lint-md: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 @@ -32,7 +32,7 @@ jobs: - name: lint run: NODE=$(which node) make lint-md - Lint_JavaScript_files: + lint-js: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 From 604c87264878a95376db8b87e0896b45965001ae Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Sun, 12 Jan 2020 00:41:05 +0000 Subject: [PATCH 10/10] just pull_request for now Avoid double annotations (one on push and one on pull_request). --- .github/workflows/blank.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/blank.yml b/.github/workflows/blank.yml index 9b5f9173cff73d..290fa491726857 100644 --- a/.github/workflows/blank.yml +++ b/.github/workflows/blank.yml @@ -1,6 +1,6 @@ name: CI -on: [push, pull_request] +on: [pull_request] jobs: lint-addon-docs: