[Android] Make db size configurable

[alexkuttig]

Summary:

Since I do need a larger max db size, I added an optional parameter to gradle properties. This makes the maximum db size configurable, while keeping the standard size of 6L * 1024L * 1024L when not giving any value. (like discussed in #83 and #98 )

Test Plan:

1.) Use test app
2.) write > 6MB data to async storage
3.) change android/gradle.properties of testapp and uncomment the last line
4.) make new build
5.) write additional data

[alexkuttig]

@krizzu I made a new Pull Request to keep the files clean.

[krizzu]

Great 👏

Left one comment and I believe we're good to go.

Any more thoughts @tido64 ? If no, feel free to merge it whenever you have a time 🎉

[krizzu]

Let's be more gentle :)

Suggested change

	# If you know what you're doing, you can uncomment this line and increase the size of db
	# This is an example of how you can change default DB size (6MB) to 10MB

[alexkuttig]

Here we go :-)

[tido64]

LGTM. I'm not as savvy on Android as I'd like to be so if @krizzu says to merge, then so be it. 👍

[krizzu]

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[mjmasn]

BTW this was already possible via onCreate() in MainApplication.java:

@Override
public void onCreate() {
    super.onCreate();
    long size = 25L * 1024L * 1024L;
    ReactDatabaseSupplier.getInstance(getApplicationContext()).setMaximumSize(size);
}

Not sure if it's worth adding that to the documentation as well?

[krizzu]

@mjmasn Hey,

I don't think it's worth adding. Setting values in gradle.properties are more user friendly IMO.