fix: AsyncStorage doesn't depend on react
#579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilson0x4d
approved these changes
Apr 3, 2021
There was a problem hiding this comment.
+1 -- i confirmed this resolves my peer deps error reported in issue #578
i used the following spec in my package.json to pull from the PR branch, npm install executes successfully and AsyncStorage works as intended in the target application (phy Android device):
"@react-native-async-storage/async-storage": "[email protected]:react-native-async-storage/async-storage.git#tido/remove-react-dependency",
|
🎉 This PR is included in version 1.15.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
AsyncStorage doesn't depend on
reactbut declares it inpackage.json.Resolves #578.
Test Plan
CI should pass.