chore: remove .expo extension in favor of generic fallback to legacy native module mechanism #544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krizzu
reviewed
Feb 16, 2021
brentvatne
force-pushed
the
@brent/remove-expo-extension
branch
from
deb88bf to
71b84a2
Compare
|
🎉 This PR is included in version 1.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Expo is moving away from
.expo.jsfiles, so for async-storage to continue working I have moved the environment check to ashouldFallbackToLegacyNativeModule()function instead ofRCTAsyncStorage.expo.js. This function is only invoked if the native modules that ship with this library are not defined.Test Plan
yarn testyarn startyarn start:ios