fix: add react 17 to peer dependencies #536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tido64
commented
Jan 29, 2021
Our React version requirement needs to match what react-native depends on. Changing it to specific versions rather than a blanket 16.x or 17.x to ensure that we stay compatible.
tido64
force-pushed
the
tido64/fix-peer-deps
branch
from
7cd1e0b to
5ac782e
Compare
|
🎉 This PR is included in version 1.13.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@tido64 , by this update, we cannot use async-storage blow react-native 0.59, right? |
|
@atokuswanto: Strictly speaking, you still can. You'll get a warning that requirements aren't met but I think you'll be fine. I don't think we require anything that will break on 0.59. That said, 0.59 is several years old now. The further you get from latest version, the harder it will be to migrate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our React version requirement needs to match what react-native depends
on. Changing it to specific versions rather than a blanket 16.x or 17.x
to make sure that we stay compatible.
Resolves #535.
Test Plan
No tests needed. CI should pass.