Skip to content

Commit 5ab6602

Browse files
tido64Krzysztof Borowy
authored and
Krzysztof Borowy
committed
fix: failing to find headers when linked with Pods. (#75)
Summary: --------- Multiple people have reported that RNCAsyncStorage fails to build after #35. See #35 (comment), #73, and #74. After a little discussion, we agreed to rename the `.podspec` and the name of the Pod to be more in line with Apple's naming guidelines and the rest of the community. Unfortunately, this means that the next upgrade will break. I got a little impatient knowing that I broke the latest release so I went ahead and implemented the fix. Sorry if you've already started looking at this. Migration Plan: --------------- Even though `react-native link` will be able to link the new `.podspec`, it won't clean up existing entries. Please find your Podfile, and make the following changes: ```diff - pod 'react-native-async-storage', :path => '../node_modules/@react-native-community/async-storage' + pod 'RNCAsyncStorage', :path => '../node_modules/@react-native-community/async-storage' ```
1 parent 42fec96 commit 5ab6602

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

react-native-async-storage.podspec renamed to RNCAsyncStorage.podspec

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ require 'json'
33
package = JSON.parse(File.read(File.join(__dir__, 'package.json')))
44

55
Pod::Spec.new do |s|
6-
s.name = "react-native-async-storage"
6+
s.name = "RNCAsyncStorage"
77
s.version = package['version']
88
s.summary = package['description']
99
s.license = package['license']

docs/Linking.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@
1414
#### Using 'Pods'
1515
1. Enter into iOS Folder `cd ios/` (on your project's root folder).
1616

17-
2. Add this line to your `Podfile` just below the last pod: (if you don't one just create a new runnning: `pod init`).
17+
2. Add this line to your `Podfile` just below the last pod (if you don't have one, you can create it by running `pod init`):
1818

1919
```diff
20-
+ pod 'react-native-async-storage', :path => '../node_modules/@react-native-community/async-storage'
20+
+ pod 'RNCAsyncStorage', :path => '../node_modules/@react-native-community/async-storage'
2121
```
2222

2323
3. Run `pod install`

0 commit comments

Comments
 (0)