Skip to content

Add upstream flatcc option to avoid installing under the source tree #8867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dbort opened this issue Mar 1, 2025 · 0 comments
Open

Add upstream flatcc option to avoid installing under the source tree #8867

dbort opened this issue Mar 1, 2025 · 0 comments
Assignees
Labels
actionable Items in the backlog waiting for an appropriate impl/fix module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@dbort
Copy link
Contributor

dbort commented Mar 1, 2025

The flatcc third party library builds its libraries and executables directly into its source tree (under bin/ and lib/) instead of into the cmake output directory. This causes problems for us, because we need to be able to build both host and cross-compiled target versions of flatcc. But since they both are built to the same directory, they can overwrite each other.

We have a hack at

# TODO(dbort): flatcc installs its files directly in its source directory
to deal with this, but it'd be a lot easier if flatcc had a build option to install the binaries under the cmake build directory instead.

@dbort sent dvidelabs/flatcc#306 to the upstream project, but there's been no further response for months.

db31f49 is the simplification change we'll be able to make to ET. And that hack didn't work all the time anyway (e.g., #7260), so with this we should be able to permanently avoid the environment-specific build race conditions we've run into.

cc @larryliu0820 @lucylq

@dbort dbort added actionable Items in the backlog waiting for an appropriate impl/fix module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Mar 1, 2025
@github-project-automation github-project-automation bot moved this to To triage in ExecuTorch Core Mar 1, 2025
@tarun292 tarun292 moved this from To triage to Ready in ExecuTorch Core Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actionable Items in the backlog waiting for an appropriate impl/fix module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
Status: Ready
Development

No branches or pull requests

2 participants