Skip to content

pass rustflags to isolated environemnt #12935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
n-bes opened this issue Aug 24, 2024 · 3 comments
Closed
1 task done

pass rustflags to isolated environemnt #12935

n-bes opened this issue Aug 24, 2024 · 3 comments
Labels
C: build isolation resolution: no action When the resolution is to not do anything type: feature request Request for a new feature

Comments

@n-bes
Copy link

n-bes commented Aug 24, 2024

What's the problem this feature will solve?

I prepared example rust-lang/rust#129489 and mentioned that CC, CFLAGS passed to isolated environment, but RUSTFLAGS not

Describe the solution you'd like

pass only RUSTFLAGS to

Alternative Solutions

Allow to pip.conf read env variables from global configuration file

Additional context

I try to merge c/rust/python code with specific flags

Code of Conduct

@n-bes n-bes added S: needs triage Issues/PRs that need to be triaged type: feature request Request for a new feature labels Aug 24, 2024
@uranusjr
Copy link
Member

My memory may be wrong, but I don’t recall pip does anything special with CC and CFLAGS. Are you sure this is in pip?

@n-bes
Copy link
Author

n-bes commented Aug 30, 2024

@uranusjr, Not sure yet. I'm looking for the root cause

@ichard26 ichard26 added resolution: no action When the resolution is to not do anything C: build isolation and removed S: needs triage Issues/PRs that need to be triaged labels Apr 21, 2025
@ichard26
Copy link
Member

Pip doesn't mess with the RUSTFLAGS environment variable or any other environment variable except for PATH, PYTHONPATH, and PYTHONNOUSERSITE. All other environment variables simply pass-through to the subprocessed called under build isolation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: build isolation resolution: no action When the resolution is to not do anything type: feature request Request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants