Skip to content

Commit 07691e9

Browse files
ricardoV94twiecki
authored andcommitted
Fix Uniform logp regression from #4541
1 parent 8178ec1 commit 07691e9

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

pymc3/distributions/continuous.py

+5-3
Original file line numberDiff line numberDiff line change
@@ -253,8 +253,6 @@ class Uniform(BoundedContinuous):
253253
def dist(cls, lower=0, upper=1, **kwargs):
254254
lower = at.as_tensor_variable(floatX(lower))
255255
upper = at.as_tensor_variable(floatX(upper))
256-
# mean = (upper + lower) / 2.0
257-
# median = self.mean
258256
return super().dist([lower, upper], **kwargs)
259257

260258
def logp(value, lower, upper):
@@ -270,7 +268,11 @@ def logp(value, lower, upper):
270268
-------
271269
TensorVariable
272270
"""
273-
return bound(-at.log(upper - lower), value >= lower, value <= upper)
271+
return bound(
272+
at.fill(value, -at.log(upper - lower)),
273+
value >= lower,
274+
value <= upper,
275+
)
274276

275277
def logcdf(value, lower, upper):
276278
"""

0 commit comments

Comments
 (0)