Skip to content

Timeout description does not contain time unit of measure #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guyluz11 opened this issue Feb 3, 2022 · 0 comments
Closed

Timeout description does not contain time unit of measure #19

guyluz11 opened this issue Feb 3, 2022 · 0 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@guyluz11
Copy link

guyluz11 commented Feb 3, 2022

Timeout description does not contain time unit of measure in ping_interface.dart page

/// How long to wait for a ping to return before marking it as lost

After checking it on the Linux implementation

var params = ['-O', '-n', '-W $timeout', '-i $interval', '-t $ttl'];

I have found that the -W for ping command on Linux is in seconds

-W timeout
Time to wait for a response, in seconds. The option affects only timeout in absence of
any responses, otherwise ping waits for two RTTs. Real number allowed with dot as a
decimal separator (regardless locale setup). 0 means infinite timeout.

I think adding this to our description is important, or change timeout to timeoutInSeconds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants