Skip to content

remoteHelper throws on git ssh urls #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
losnappas opened this issue Dec 8, 2021 · 1 comment
Closed

remoteHelper throws on git ssh urls #3

losnappas opened this issue Dec 8, 2021 · 1 comment

Comments

@losnappas
Copy link

Hi, nice work with the scopes, it works nicely.

I came across this bug with repositories cloned via ssh, where this line

const uri = vscode.Uri.parse(url);
throws an error, because the url is of the form '[email protected]:user/repository-name', which isn't valid for vscode.Uri.parse and then that throws '[UriError]: Scheme contains illegal characters.'

Ex. if you clone this repo with git clone [email protected]:phoihos/vscode-git-commit-message-editor.git, then the code lens and scope suggestions break.

@phoihos phoihos closed this as completed in 6f370eb Dec 9, 2021
@phoihos
Copy link
Owner

phoihos commented Dec 9, 2021

I fixed this issue and released new version 0.6.1.
Thank you for your reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants