Skip to content

Commit 7358f09

Browse files
authored
COMPAT: make sure use_inf_as_null is deprecated (#17126)
closes #17115
1 parent f2b0bdc commit 7358f09

File tree

2 files changed

+21
-2
lines changed

2 files changed

+21
-2
lines changed

Diff for: pandas/core/config_init.py

+5-2
Original file line numberDiff line numberDiff line change
@@ -412,8 +412,11 @@ def use_inf_as_na_cb(key):
412412
_use_inf_as_na(key)
413413

414414

415-
cf.register_option('mode.use_inf_as_na', False, use_inf_as_na_doc,
416-
cb=use_inf_as_na_cb)
415+
with cf.config_prefix('mode'):
416+
cf.register_option('use_inf_as_na', False, use_inf_as_na_doc,
417+
cb=use_inf_as_na_cb)
418+
cf.register_option('use_inf_as_null', False, use_inf_as_null_doc,
419+
cb=use_inf_as_na_cb)
417420

418421
cf.deprecate_option('mode.use_inf_as_null', msg=use_inf_as_null_doc,
419422
rkey='mode.use_inf_as_na')

Diff for: pandas/tests/series/test_missing.py

+16
Original file line numberDiff line numberDiff line change
@@ -410,6 +410,22 @@ def test_isna_for_inf(self):
410410
tm.assert_series_equal(r, e)
411411
tm.assert_series_equal(dr, de)
412412

413+
@tm.capture_stdout
414+
def test_isnull_for_inf_deprecated(self):
415+
# gh-17115
416+
s = Series(['a', np.inf, np.nan, 1.0])
417+
with tm.assert_produces_warning(DeprecationWarning,
418+
check_stacklevel=False):
419+
pd.set_option('mode.use_inf_as_null', True)
420+
r = s.isna()
421+
dr = s.dropna()
422+
pd.reset_option('mode.use_inf_as_null')
423+
424+
e = Series([False, True, True, False])
425+
de = Series(['a', 1.0], index=[0, 3])
426+
tm.assert_series_equal(r, e)
427+
tm.assert_series_equal(dr, de)
428+
413429
def test_fillna(self):
414430
ts = Series([0., 1., 2., 3., 4.], index=tm.makeDateIndex(5))
415431

0 commit comments

Comments
 (0)